From: patchwork-bot+netdevbpf@kernel.org
To: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Cc: timur@kernel.org, davem@davemloft.net, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net:emac/emac-mac: Fix a use after free in emac_mac_tx_buf_send
Date: Mon, 26 Apr 2021 20:40:09 +0000 [thread overview]
Message-ID: <161946960912.8317.15351788519078792132.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210426160625.9573-1-lyl2019@mail.ustc.edu.cn>
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 26 Apr 2021 09:06:25 -0700 you wrote:
> In emac_mac_tx_buf_send, it calls emac_tx_fill_tpd(..,skb,..).
> If some error happens in emac_tx_fill_tpd(), the skb will be freed via
> dev_kfree_skb(skb) in error branch of emac_tx_fill_tpd().
> But the freed skb is still used via skb->len by netdev_sent_queue(,skb->len).
>
> As i observed that emac_tx_fill_tpd() haven't modified the value of skb->len,
> thus my patch assigns skb->len to 'len' before the possible free and
> use 'len' instead of skb->len later.
>
> [...]
Here is the summary with links:
- net:emac/emac-mac: Fix a use after free in emac_mac_tx_buf_send
https://git.kernel.org/netdev/net-next/c/6d72e7c767ac
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-04-26 20:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 16:06 [PATCH] net:emac/emac-mac: Fix a use after free in emac_mac_tx_buf_send Lv Yunlong
2021-04-26 20:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161946960912.8317.15351788519078792132.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyl2019@mail.ustc.edu.cn \
--cc=netdev@vger.kernel.org \
--cc=timur@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).