From: Allison Henderson <allison.henderson@oracle.com>
To: "kuba@kernel.org" <kuba@kernel.org>,
"achender@kernel.org" <achender@kernel.org>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"rds-devel@oss.oracle.com" <rds-devel@oss.oracle.com>,
"horms@kernel.org" <horms@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: [PATCH net v2] net/rds: rds_sendmsg should not discard payload_len
Date: Fri, 13 Feb 2026 06:39:20 +0000 [thread overview]
Message-ID: <161c459cb7c3aebe91601286e7842dc26692a850.camel@oracle.com> (raw)
In-Reply-To: <20260212190534.7faf2878@kernel.org>
On Thu, 2026-02-12 at 19:05 -0800, Jakub Kicinski wrote:
> On Tue, 10 Feb 2026 10:09:52 -0700 Allison Henderson wrote:
> > Commit 3db6e0d172c9 ("rds: use RCU to synchronize work-enqueue with
> > connection teardown") modifies rds_sendmsg to avoid enqueueing work
> > while a tear down is in progress. However, it also changed the return
> > value of rds_sendmsg to that of rds_send_xmit instead of the
> > payload_len. This means the user may incorrectly receive errno values
> > when it should have simply received a payload of 0 while the peer
> > attempts a reconnections. So this patch corrects the teardown handling
> > code to only use the out error path in that case, thus restoring the
> > original payload_len return value.
>
> net-next now became net so this no longer applies.
> Please rebase?
Sure, I've sent a rebased v3.
Thank you
Allison
prev parent reply other threads:[~2026-02-13 6:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 17:09 [PATCH net v2] net/rds: rds_sendmsg should not discard payload_len Allison Henderson
2026-02-12 18:09 ` Simon Horman
2026-02-13 3:05 ` Jakub Kicinski
2026-02-13 6:39 ` Allison Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161c459cb7c3aebe91601286e7842dc26692a850.camel@oracle.com \
--to=allison.henderson@oracle.com \
--cc=achender@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox