* [PATCH net-next] devlink: Fix error message in devlink_rate_set_ops_supported()
@ 2021-06-09 9:54 Dan Carpenter
2021-06-09 21:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-06-09 9:54 UTC (permalink / raw)
To: Jiri Pirko, Dmytro Linkin
Cc: David S. Miller, Jakub Kicinski, Vlad Buslov, netdev,
kernel-janitors
The WARN_ON() macro takes a condition, it doesn't take a message. Use
WARN() instead.
Fixes: 1897db2ec310 ("devlink: Allow setting tx rate for devlink rate leaf objects")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
net/core/devlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index 1e953b77a77a..4a5b333c05a0 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -1732,7 +1732,7 @@ static bool devlink_rate_set_ops_supported(const struct devlink_ops *ops,
return false;
}
} else {
- WARN_ON("Unknown type of rate object");
+ WARN(1, "Unknown type of rate object");
return false;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] devlink: Fix error message in devlink_rate_set_ops_supported()
2021-06-09 9:54 [PATCH net-next] devlink: Fix error message in devlink_rate_set_ops_supported() Dan Carpenter
@ 2021-06-09 21:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-09 21:20 UTC (permalink / raw)
To: Dan Carpenter; +Cc: jiri, dlinkin, davem, kuba, vladbu, netdev, kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 9 Jun 2021 12:54:31 +0300 you wrote:
> The WARN_ON() macro takes a condition, it doesn't take a message. Use
> WARN() instead.
>
> Fixes: 1897db2ec310 ("devlink: Allow setting tx rate for devlink rate leaf objects")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> net/core/devlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net-next] devlink: Fix error message in devlink_rate_set_ops_supported()
https://git.kernel.org/netdev/net-next/c/711d1dee1c86
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-09 21:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-09 9:54 [PATCH net-next] devlink: Fix error message in devlink_rate_set_ops_supported() Dan Carpenter
2021-06-09 21:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).