From: Peng Li <lipeng321@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>, <xie.he.0141@gmail.com>,
<ms@dev.tdt.de>, <willemb@google.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<huangguangbin2@huawei.com>
Subject: [PATCH net-next 3/6] net: pci200syn: replace comparison to NULL with "!card"
Date: Tue, 15 Jun 2021 21:54:20 +0800 [thread overview]
Message-ID: <1623765263-36775-4-git-send-email-lipeng321@huawei.com> (raw)
In-Reply-To: <1623765263-36775-1-git-send-email-lipeng321@huawei.com>
According to the chackpatch.pl, comparison to NULL could
be written "!card".
Signed-off-by: Peng Li <lipeng321@huawei.com>
---
drivers/net/wan/pci200syn.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wan/pci200syn.c b/drivers/net/wan/pci200syn.c
index a7eac90..cee3d65 100644
--- a/drivers/net/wan/pci200syn.c
+++ b/drivers/net/wan/pci200syn.c
@@ -279,7 +279,7 @@ static int pci200_pci_init_one(struct pci_dev *pdev,
}
card = kzalloc(sizeof(card_t), GFP_KERNEL);
- if (card == NULL) {
+ if (!card) {
pci_release_regions(pdev);
pci_disable_device(pdev);
return -ENOBUFS;
@@ -310,9 +310,7 @@ static int pci200_pci_init_one(struct pci_dev *pdev,
ramphys = pci_resource_start(pdev,3) & PCI_BASE_ADDRESS_MEM_MASK;
card->rambase = pci_ioremap_bar(pdev, 3);
- if (card->plxbase == NULL ||
- card->scabase == NULL ||
- card->rambase == NULL) {
+ if (!card->plxbase || !card->scabase || !card->rambase) {
pr_err("ioremap() failed\n");
pci200_pci_remove_one(pdev);
return -EFAULT;
--
2.8.1
next prev parent reply other threads:[~2021-06-15 13:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 13:54 [PATCH net-next 0/6] net: pci200syn: clean up some code style issues Peng Li
2021-06-15 13:54 ` [PATCH net-next 1/6] net: pci200syn: remove redundant blank lines Peng Li
2021-06-15 13:54 ` [PATCH net-next 2/6] net: pci200syn: add blank line after declarations Peng Li
2021-06-15 13:54 ` Peng Li [this message]
2021-06-15 13:54 ` [PATCH net-next 4/6] net: pci200syn: add some required spaces Peng Li
2021-06-15 13:54 ` [PATCH net-next 5/6] net: pci200syn: add necessary () to macro argument Peng Li
2021-06-15 13:54 ` [PATCH net-next 6/6] net: pci200syn: fix the comments style issue Peng Li
2021-06-15 18:20 ` [PATCH net-next 0/6] net: pci200syn: clean up some code style issues patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623765263-36775-4-git-send-email-lipeng321@huawei.com \
--to=lipeng321@huawei.com \
--cc=davem@davemloft.net \
--cc=huangguangbin2@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).