From: Robert Olsson <Robert.Olsson@data.slu.se>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Robert Olsson <Robert.Olsson@data.slu.se>,
Andrew Morton <akpm@osdl.org>,
netdev@oss.sgi.com, dfages@arkoon.net
Subject: Re: Fw: [BUG/PATCH] CONFIG_NET_HW_FLOWCONTROL and SMP
Date: Fri, 3 Oct 2003 16:10:33 +0200 [thread overview]
Message-ID: <16253.33625.541433.36206@robur.slu.se> (raw)
In-Reply-To: <3F7C64BC.7030701@pobox.com>
Jeff Garzik writes:
>
> Looks great to me. I'll give it some testing here, and 99% likely will
> apply it.
>
> Andrew, would you be willing to merge this into -mm for some
> simultaneous netwide testing?
Fine!
Here is a additional patch to active disable poll so we don't have to wait in
dev_close() for traffic to disappear.
Cheers.
--ro
--- drivers/net/tulip/interrupt.c.03103 2001-11-03 18:52:54.000000000 +0100
+++ drivers/net/tulip/interrupt.c 2003-10-03 13:21:46.000000000 +0200
@@ -116,6 +116,8 @@
tp->stats_poll_starts++;
#endif
+ if(!netif_running(dev)) goto done;
+
if (rx_work_limit > dev->quota)
rx_work_limit = dev->quota;
@@ -241,7 +243,7 @@
* finally: amount of IO did not increase at all. */
} while ((inl(dev->base_addr + CSR5) & RxIntr));
-/* done: */
+done:
#ifdef USE_MITIGATION
next prev parent reply other threads:[~2003-10-03 14:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-29 19:37 Fw: [BUG/PATCH] CONFIG_NET_HW_FLOWCONTROL and SMP Andrew Morton
2003-09-29 21:25 ` Robert Olsson
2003-09-29 21:39 ` Jeff Garzik
2003-09-30 14:45 ` Robert Olsson
2003-10-02 15:31 ` Robert Olsson
2003-10-02 17:47 ` Jeff Garzik
2003-10-02 19:34 ` Andrew Morton
2003-10-03 14:10 ` Robert Olsson [this message]
2003-09-30 2:17 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16253.33625.541433.36206@robur.slu.se \
--to=robert.olsson@data.slu.se \
--cc=akpm@osdl.org \
--cc=dfages@arkoon.net \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).