From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00F16C10F13 for ; Mon, 8 Apr 2019 20:56:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF18D20863 for ; Mon, 8 Apr 2019 20:56:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="kxZ3nayz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727013AbfDHU4p (ORCPT ); Mon, 8 Apr 2019 16:56:45 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:43430 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726547AbfDHU4p (ORCPT ); Mon, 8 Apr 2019 16:56:45 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x38Kn304066107; Mon, 8 Apr 2019 20:56:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : references : cc : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=j8uJWGqAMwvAOoTJUDsgKovnWvSMO0+OwNKQkd8bI4c=; b=kxZ3nayzyy3g4iJ3kb4XFaIJ5DSm3JdLI/AC3mJIFvxX087prYWO9vn328opjHJcG3qx SRf33BQc2gcTMvYGIfbAd+7ZrnJAdVG+4RVO5gMjvFlV+ktUgCd/3NbaZh3/7iByQ6vm gglZkQ/nmBQZMe6B5e+BTFCOp7ZcKHRyvYhuqppYYzhg8vVUZN0g+SAt4KOSU3EM7UNx b9orJM+zNoHM17AavPe2lxXhSUNdglYd7qb8PtWtN2V+yNfN96Mbiikp4Kt8szgeSeNQ Az/bV/1yL6pE7OKI+kicrD+rq46nuZNenlCsoiJ7ndc/Yx0G2UUazGIO8xmZ6T7ofiT5 0w== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2rpmrq10mb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Apr 2019 20:56:35 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x38Ktn1V159432; Mon, 8 Apr 2019 20:56:35 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 2rpkehww4v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Apr 2019 20:56:35 +0000 Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x38KuY4v024727; Mon, 8 Apr 2019 20:56:34 GMT Received: from [10.159.255.59] (/10.159.255.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 08 Apr 2019 13:56:33 -0700 Subject: Re: [PATCH net v6] failover: allow name change on IFF_UP slave interfaces To: "Samudrala, Sridhar" , Stephen Hemminger , "Michael S. Tsirkin" References: <1554267167-17561-1-git-send-email-si-wei.liu@oracle.com> <20190405172835-mutt-send-email-mst@kernel.org> <20190405144750.441e396f@shemminger-XPS-13-9360> <7d1c3488-2d55-213f-b744-c71b665aa387@intel.com> Cc: davem@davemloft.net, kubakici@wp.pl, alexander.duyck@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, liran.alon@oracle.com, boris.ostrovsky@oracle.com, vijay.balakrishna@oracle.com From: si-wei liu Organization: Oracle Corporation Message-ID: <16257d70-c8c6-a84e-9611-e8fadfc059c7@oracle.com> Date: Mon, 8 Apr 2019 13:56:28 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <7d1c3488-2d55-213f-b744-c71b665aa387@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9221 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904080154 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9221 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904080154 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/6/2019 7:45 PM, Samudrala, Sridhar wrote: > > On 4/6/2019 12:21 AM, si-wei liu wrote: > >>>> >>>> Stephen are you happy with this approach? >>> I think it is the best solution for what you want to do. >> >> Since you're asking specifically, I tried what you suggested below. >> >>> Did you test with some things like Free Range Routing, >> >> Although there might be spurious warning (which is a check for sanity >> more than an error) while slave interface is up, slave rename had >> been handled quite well there, no matter which state slave is at. >> >> https://github.com/FRRouting/frr/blob/master/zebra/if_netlink.c#L97 >> >> The FRR users are supposed to operate on failover master interface >> anyway. No one is expected to configure those passive interfaces for >> routing. >> >>> VPP >> Nothing particular was seen for this one. The netlink usage there >> doesn't seem related to my change: >> https://github.com/FDio/vpp/blob/master/src/vnet/devices/netlink.c >> >>> or other userspace >>> control planes that consume netlink? >> dhcpcd (https://github.com/kobolabs/dhcpcd/blob/kobo/if-linux.c#L761) >> was tested OK. >> >> In addition, the patch seems to play quite well with systemd-udev and >> dracut/initramfs-tools. No breakage, no weird error message was seen. >> >> What else do you suggest we should try/test with? > > Thanks Siwei for all the tests you are trying out. Did you notice that > any of these tests required the NETDEV_CHANGE notifier that you added? No, that is not actually needed - none of NETDEV_CHANGE consumers checks for name change, although name change was reflected there already. I retested userspace applications above with NETDEV_CHANGE notifier removed, the results remainl same. Thanks, -Siwei > > -Sridhar