From: Robert Olsson <Robert.Olsson@data.slu.se>
To: "Feldman, Scott" <scott.feldman@intel.com>
Cc: "Robert Olsson" <Robert.Olsson@data.slu.se>,
"Jeff Garzik" <jgarzik@pobox.com>, <netdev@oss.sgi.com>
Subject: RE: e1000 close (NAPI)
Date: Wed, 8 Oct 2003 11:16:02 +0200 [thread overview]
Message-ID: <16259.54738.75122.134408@robur.slu.se> (raw)
In-Reply-To: <C6F5CF431189FA4CBAEC9E7DD5441E0102229702@orsmsx402.jf.intel.com>
Feldman, Scott writes:
> > - if(work_done < work_to_do) {
> > + if(work_done < work_to_do || !netif_running(netdev)) {
> > netif_rx_complete(netdev);
> > e1000_irq_enable(adapter);
> > }
>
> Is e1000 unique in this regard, or do the other NAPI-enabled drivers
> have the same issue?
Hello!
Other drivers may have the same issue. This was spotted while stress-testing
tulip. Patch was sent here some days ago. It's only seen if trying to close
device under extreme loads. See the syncing code in dev_close()
You may try the e100 as well. We update the docs when see that this is OK.
Cheers.
--ro
next prev parent reply other threads:[~2003-10-08 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 5:58 e1000 close (NAPI) Feldman, Scott
2003-10-08 9:16 ` Robert Olsson [this message]
2003-10-08 12:07 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2003-10-10 18:45 Feldman, Scott
2003-10-07 12:34 Robert Olsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16259.54738.75122.134408@robur.slu.se \
--to=robert.olsson@data.slu.se \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=scott.feldman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).