netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
	Jakub Kicinski <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Jonathan Toppins <jtoppins@redhat.com>,
	Veaceslav Falico <vfalico@gmail.com>,
	Andy Gospodarek <andy@greyhouse.net>,
	Hangbin Liu <liuhangbin@gmail.com>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>,
	Nikolay Aleksandrov <razor@blackwall.org>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3 net 1/4] net: bonding: replace dev_trans_start() with the jiffies of the last ARP/NS
Date: Tue, 02 Aug 2022 11:00:41 -0700	[thread overview]
Message-ID: <16274.1659463241@famine> (raw)
In-Reply-To: <e11a02756a3253362a1ef17c8b43478b68cc15ba.camel@redhat.com>

Paolo Abeni <pabeni@redhat.com> wrote:

>On Tue, 2022-08-02 at 16:30 +0000, Vladimir Oltean wrote:
>> On Tue, Aug 02, 2022 at 09:11:10AM -0700, Jakub Kicinski wrote:
>> > On Tue, 02 Aug 2022 11:05:19 +0200 Paolo Abeni wrote:
>> > > In any case, this looks like a significative rework, do you mind
>> > > consider it for the net-next, when it re-open?
>> > 
>> > It does seem like it could be a lot for stable.
>
>I'm sorry, I did not intend to block the series. It looked to me there
>was no agreement on this, and I was wondering if a net-next target
>would allow a clean solution to make eveyone happy.
>
>I now see it's relevant to have something we can queue for stable.
>
>I'm ok with Jay suggestion:
>> Alternatively, would it be more comfortable to just put this
>> patch (1/4) to stable and not backport the others? 
>
>The above works for me - I thought it was not ok for Jay, but since he
>is proposing such sulution, I guess I was wrong.

	My original reluctance was that I hadn't had an opportunity to
sufficiently review the patch set to think through the potential
regressions.  There might be something I haven't thought of, but I think
would only manifest in very unusual configurations.

	I'm ok with applying the series to net-next when it's available,
and backporting 1/4 for stable (and 4/4 with it, since that's the
documentation update).

Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>

	-J

---
	-Jay Vosburgh, jay.vosburgh@canonical.com

  reply	other threads:[~2022-08-02 18:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-31 12:41 [PATCH v3 net 0/4] Make DSA work with bonding's ARP monitor Vladimir Oltean
2022-07-31 12:41 ` [PATCH v3 net 1/4] net: bonding: replace dev_trans_start() with the jiffies of the last ARP/NS Vladimir Oltean
2022-07-31 18:53   ` Jay Vosburgh
2022-07-31 19:13     ` Vladimir Oltean
2022-08-02  1:04       ` Jay Vosburgh
2022-08-02  1:45         ` Vladimir Oltean
2022-08-02  9:05           ` Paolo Abeni
2022-08-02 16:11             ` Jakub Kicinski
2022-08-02 16:29               ` Jay Vosburgh
2022-08-02 16:30               ` Vladimir Oltean
2022-08-02 17:33                 ` Paolo Abeni
2022-08-02 18:00                   ` Jay Vosburgh [this message]
2022-08-02 19:10                     ` Jakub Kicinski
2022-08-02 20:24                       ` Jay Vosburgh
2022-08-02 20:33                         ` Jakub Kicinski
2022-08-02 20:34                         ` Paolo Abeni
2022-07-31 12:41 ` [PATCH v3 net 2/4] net/sched: remove hacks added to dev_trans_start() for bonding to work Vladimir Oltean
2022-07-31 12:41 ` [PATCH v3 net 3/4] Revert "veth: Add updating of trans_start" Vladimir Oltean
2022-07-31 12:41 ` [PATCH v3 net 4/4] docs: net: bonding: remove mentions of trans_start Vladimir Oltean
2022-08-01 17:58 ` [PATCH v3 net 0/4] Make DSA work with bonding's ARP monitor Jakub Kicinski
2022-08-01 23:39   ` Vladimir Oltean
2022-08-04  2:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16274.1659463241@famine \
    --to=jay.vosburgh@canonical.com \
    --cc=andrew@lunn.ch \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=jtoppins@redhat.com \
    --cc=kuba@kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    --cc=stephen@networkplumber.org \
    --cc=vfalico@gmail.com \
    --cc=vivien.didelot@gmail.com \
    --cc=vladimir.oltean@nxp.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).