* [net,v2] net: dsa: lantiq_gswip: Add 200ms assert delay
@ 2021-09-12 11:58 Aleksander Jan Bajkowski
2021-09-12 12:14 ` Hauke Mehrtens
2021-09-13 12:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Aleksander Jan Bajkowski @ 2021-09-12 11:58 UTC (permalink / raw)
To: hauke, andrew, vivien.didelot, f.fainelli, olteanv, davem, kuba,
olek2, netdev, linux-kernel
Cc: Martin Blumenstingl
The delay is especially needed by the xRX300 and xRX330 SoCs. Without
this patch, some phys are sometimes not properly detected.
The patch was tested on BT Home Hub 5A and D-Link DWR-966.
Fixes: a09d042b0862 ("net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330")
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
drivers/net/dsa/lantiq_gswip.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
index 64d6dfa83122..267324889dd6 100644
--- a/drivers/net/dsa/lantiq_gswip.c
+++ b/drivers/net/dsa/lantiq_gswip.c
@@ -1885,6 +1885,12 @@ static int gswip_gphy_fw_load(struct gswip_priv *priv, struct gswip_gphy_fw *gph
reset_control_assert(gphy_fw->reset);
+ /* The vendor BSP uses a 200ms delay after asserting the reset line.
+ * Without this some users are observing that the PHY is not coming up
+ * on the MDIO bus.
+ */
+ msleep(200);
+
ret = request_firmware(&fw, gphy_fw->fw_name, dev);
if (ret) {
dev_err(dev, "failed to load firmware: %s, error: %i\n",
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [net,v2] net: dsa: lantiq_gswip: Add 200ms assert delay
2021-09-12 11:58 [net,v2] net: dsa: lantiq_gswip: Add 200ms assert delay Aleksander Jan Bajkowski
@ 2021-09-12 12:14 ` Hauke Mehrtens
2021-09-13 12:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Hauke Mehrtens @ 2021-09-12 12:14 UTC (permalink / raw)
To: Aleksander Jan Bajkowski, andrew, vivien.didelot, f.fainelli,
olteanv, davem, kuba, netdev, linux-kernel
Cc: Martin Blumenstingl
On 9/12/21 1:58 PM, Aleksander Jan Bajkowski wrote:
> The delay is especially needed by the xRX300 and xRX330 SoCs. Without
> this patch, some phys are sometimes not properly detected.
>
> The patch was tested on BT Home Hub 5A and D-Link DWR-966.
>
> Fixes: a09d042b0862 ("net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> drivers/net/dsa/lantiq_gswip.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
> index 64d6dfa83122..267324889dd6 100644
> --- a/drivers/net/dsa/lantiq_gswip.c
> +++ b/drivers/net/dsa/lantiq_gswip.c
> @@ -1885,6 +1885,12 @@ static int gswip_gphy_fw_load(struct gswip_priv *priv, struct gswip_gphy_fw *gph
>
> reset_control_assert(gphy_fw->reset);
>
> + /* The vendor BSP uses a 200ms delay after asserting the reset line.
> + * Without this some users are observing that the PHY is not coming up
> + * on the MDIO bus.
> + */
> + msleep(200);
> +
> ret = request_firmware(&fw, gphy_fw->fw_name, dev);
> if (ret) {
> dev_err(dev, "failed to load firmware: %s, error: %i\n",
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [net,v2] net: dsa: lantiq_gswip: Add 200ms assert delay
2021-09-12 11:58 [net,v2] net: dsa: lantiq_gswip: Add 200ms assert delay Aleksander Jan Bajkowski
2021-09-12 12:14 ` Hauke Mehrtens
@ 2021-09-13 12:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-13 12:10 UTC (permalink / raw)
To: Aleksander Jan Bajkowski
Cc: hauke, andrew, vivien.didelot, f.fainelli, olteanv, davem, kuba,
netdev, linux-kernel, martin.blumenstingl
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Sun, 12 Sep 2021 13:58:07 +0200 you wrote:
> The delay is especially needed by the xRX300 and xRX330 SoCs. Without
> this patch, some phys are sometimes not properly detected.
>
> The patch was tested on BT Home Hub 5A and D-Link DWR-966.
>
> Fixes: a09d042b0862 ("net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> [...]
Here is the summary with links:
- [net,v2] net: dsa: lantiq_gswip: Add 200ms assert delay
https://git.kernel.org/netdev/net/c/111b64e35ea0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-13 12:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-12 11:58 [net,v2] net: dsa: lantiq_gswip: Add 200ms assert delay Aleksander Jan Bajkowski
2021-09-12 12:14 ` Hauke Mehrtens
2021-09-13 12:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox