From: patchwork-bot+netdevbpf@kernel.org
To: Thomas Gleixner <tglx@linutronix.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
mingo@kernel.org, peterz@infradead.org, bigeasy@linutronix.de
Subject: Re: [patch] net: core: Correct the sock::sk_lock.owned lockdep annotations
Date: Sun, 19 Sep 2021 12:10:08 +0000 [thread overview]
Message-ID: <163205340825.3254.11987805094738440197.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210918114626.399467843@linutronix.de>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Sat, 18 Sep 2021 14:42:35 +0200 (CEST) you wrote:
> lock_sock_fast() and lock_sock_nested() contain lockdep annotations for the
> sock::sk_lock.owned 'mutex'. sock::sk_lock.owned is not a regular mutex. It
> is just lockdep wise equivalent. In fact it's an open coded trivial mutex
> implementation with some interesting features.
>
> sock::sk_lock.slock is a regular spinlock protecting the 'mutex'
> representation sock::sk_lock.owned which is a plain boolean. If 'owned' is
> true, then some other task holds the 'mutex', otherwise it is uncontended.
> As this locking construct is obviously endangered by lock ordering issues as
> any other locking primitive it got lockdep annotated via a dedicated
> dependency map sock::sk_lock.dep_map which has to be updated at the lock
> and unlock sites.
>
> [...]
Here is the summary with links:
- net: core: Correct the sock::sk_lock.owned lockdep annotations
https://git.kernel.org/netdev/net/c/2dcb96bacce3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-09-19 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 12:42 [patch] net: core: Correct the sock::sk_lock.owned lockdep annotations Thomas Gleixner
2021-09-19 12:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163205340825.3254.11987805094738440197.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).