* [PATCH net-next] net: tg3: fix redundant check of true expression
@ 2021-10-08 6:31 Jεan Sacren
2021-10-08 8:02 ` Michael Chan
2021-10-09 0:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jεan Sacren @ 2021-10-08 6:31 UTC (permalink / raw)
To: Siva Reddy Kallam; +Cc: prashant, mchan, davem, kuba, netdev
From: Jean Sacren <sakiwit@gmail.com>
Remove the redundant check of (tg3_asic_rev(tp) == ASIC_REV_5705) after
it is checked to be true.
Signed-off-by: Jean Sacren <sakiwit@gmail.com>
---
drivers/net/ethernet/broadcom/tg3.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index 5a50ea75094f..32d486114a6d 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -10273,8 +10273,7 @@ static int tg3_reset_hw(struct tg3 *tp, bool reset_phy)
if (tg3_asic_rev(tp) == ASIC_REV_5705 &&
tg3_chip_rev_id(tp) != CHIPREV_ID_5705_A0) {
- if (tg3_flag(tp, TSO_CAPABLE) &&
- tg3_asic_rev(tp) == ASIC_REV_5705) {
+ if (tg3_flag(tp, TSO_CAPABLE)) {
rdmac_mode |= RDMAC_MODE_FIFO_SIZE_128;
} else if (!(tr32(TG3PCI_PCISTATE) & PCISTATE_BUS_SPEED_HIGH) &&
!tg3_flag(tp, IS_5788)) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: tg3: fix redundant check of true expression
2021-10-08 6:31 [PATCH net-next] net: tg3: fix redundant check of true expression Jεan Sacren
@ 2021-10-08 8:02 ` Michael Chan
2021-10-09 0:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Michael Chan @ 2021-10-08 8:02 UTC (permalink / raw)
To: Jεan Sacren
Cc: Siva Reddy Kallam, Prashant Sreedharan, Michael Chan,
David Miller, Jakub Kicinski, Netdev
On Thu, Oct 7, 2021 at 11:32 PM Jεan Sacren <sakiwit@gmail.com> wrote:
>
> From: Jean Sacren <sakiwit@gmail.com>
>
> Remove the redundant check of (tg3_asic_rev(tp) == ASIC_REV_5705) after
> it is checked to be true.
>
> Signed-off-by: Jean Sacren <sakiwit@gmail.com>
Thanks.
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: tg3: fix redundant check of true expression
2021-10-08 6:31 [PATCH net-next] net: tg3: fix redundant check of true expression Jεan Sacren
2021-10-08 8:02 ` Michael Chan
@ 2021-10-09 0:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-09 0:00 UTC (permalink / raw)
To: =?utf-8?q?J=CE=B5an_Sacren_=3Csakiwit=40gmail=2Ecom=3E?=
Cc: siva.kallam, prashant, mchan, davem, kuba, netdev
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 8 Oct 2021 00:31:47 -0600 you wrote:
> From: Jean Sacren <sakiwit@gmail.com>
>
> Remove the redundant check of (tg3_asic_rev(tp) == ASIC_REV_5705) after
> it is checked to be true.
>
> Signed-off-by: Jean Sacren <sakiwit@gmail.com>
>
> [...]
Here is the summary with links:
- [net-next] net: tg3: fix redundant check of true expression
https://git.kernel.org/netdev/net-next/c/6ed3f61e3200
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-09 0:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-08 6:31 [PATCH net-next] net: tg3: fix redundant check of true expression Jεan Sacren
2021-10-08 8:02 ` Michael Chan
2021-10-09 0:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).