[PATCH ethtool v2 0/1] Fix condition for showing MDI-X status

[PATCH ethtool v2 0/1] Fix condition for showing MDI-X status

[bage]

From: Bastian Germann <bage@linutronix.de>

Fix a duplicate condition in the filter for showing MDI-X info.
I am not intending to continue on this issue, so I am dropping
the second patch (invalid for the current kernel side handling).

Changelog:
 v2: - Collect the additional tags
     - Drop the 2nd patch with the twisted pair port condition

Bastian Germann (1):
  netlink: settings: Correct duplicate condition

 netlink/settings.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.30.2

[PATCH ethtool v2 1/1] netlink: settings: Correct duplicate condition

[bage]

From: Bastian Germann <bage@linutronix.de>

tb's fields ETHTOOL_A_LINKINFO_TP_MDIX and ETHTOOL_A_LINKINFO_TP_MDIX_CTRL
are used in this case. The condition is duplicate for the former. Fix that.

Signed-off-by: Bastian Germann <bage@linutronix.de>
Fixes: 10cc3ea337d1 ("netlink: partial netlink handler for gset (no option)")
Acked-by: Michal Kubecek <mkubecek@suse.cz>
---
 netlink/settings.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/netlink/settings.c b/netlink/settings.c
index 6d10a07..c4f5d61 100644
--- a/netlink/settings.c
+++ b/netlink/settings.c
@@ -560,7 +560,7 @@ int linkinfo_reply_cb(const struct nlmsghdr *nlhdr, void *data)
 		print_enum(names_transceiver, ARRAY_SIZE(names_transceiver),
 			   val, "Transceiver");
 	}
-	if (tb[ETHTOOL_A_LINKINFO_TP_MDIX] && tb[ETHTOOL_A_LINKINFO_TP_MDIX] &&
+	if (tb[ETHTOOL_A_LINKINFO_TP_MDIX] && tb[ETHTOOL_A_LINKINFO_TP_MDIX_CTRL] &&
 	    port == PORT_TP) {
 		uint8_t mdix = mnl_attr_get_u8(tb[ETHTOOL_A_LINKINFO_TP_MDIX]);
 		uint8_t mdix_ctrl =
-- 
2.30.2

Re: [PATCH ethtool v2 0/1] Fix condition for showing MDI-X status

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to ethtool/ethtool.git (master)
by Michal Kubecek <mkubecek@suse.cz>:

On Tue,  9 Nov 2021 18:21:24 +0100 you wrote:
> From: Bastian Germann <bage@linutronix.de>
> 
> Fix a duplicate condition in the filter for showing MDI-X info.
> I am not intending to continue on this issue, so I am dropping
> the second patch (invalid for the current kernel side handling).
> 
> Changelog:
>  v2: - Collect the additional tags
>      - Drop the 2nd patch with the twisted pair port condition
> 
> [...]

Here is the summary with links:
  - [ethtool,v2,1/1] netlink: settings: Correct duplicate condition
    https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=fd7db6457916

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html