From: Arnd Bergmann <arnd@arndb.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>,
Lucas Stach <l.stach@pengutronix.de>,
Fugang Duan <B38611@freescale.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v2] net: fec: make driver endian-safe
Date: Sun, 24 Jan 2016 17:49:54 +0100 [thread overview]
Message-ID: <1637940.UNKGUmXJxm@wuerfel> (raw)
In-Reply-To: <1453650757-27459-1-git-send-email-johannes@sipsolutions.net>
On Sunday 24 January 2016 16:52:37 Johannes Berg wrote:
> It's not clear that the ifdef there really is correct and shouldn't
> just be #ifdef CONFIG_ARM, but I also can't test on anything but the
> i.MX6 HummingBoard where this gets it working with a BE kernel.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
I'd argue that the "(CONFIG_ARCH_MXC) || defined(CONFIG_SOC_IMX28)"
is definitely wrong, because if we ever get another ARM platform
that uses this driver, it may or may not work depending on whether
the ARCH_MXC is also set, and that is not a helpful behavior.
Better make it simply CONFIG_ARM to keep the behavior independent
of config options. It won't change anything for now but any future
platform will probably work independent of configuration or would
require a bugfix at all.
Arnd
next prev parent reply other threads:[~2016-01-24 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-24 15:52 [PATCH v2] net: fec: make driver endian-safe Johannes Berg
2016-01-24 16:49 ` Arnd Bergmann [this message]
2016-01-24 19:12 ` Johannes Berg
2016-01-25 0:52 ` Greg Ungerer
2016-01-25 7:53 ` Johannes Berg
2016-01-25 18:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1637940.UNKGUmXJxm@wuerfel \
--to=arnd@arndb.de \
--cc=B38611@freescale.com \
--cc=gerg@uclinux.org \
--cc=johannes@sipsolutions.net \
--cc=l.stach@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox