From: patchwork-bot+netdevbpf@kernel.org
To: Antoine Tenart <atenart@kernel.org>
Cc: davem@davemloft.net, kuba@kernel.org, alexander.duyck@gmail.com,
mkubecek@suse.cz, netdev@vger.kernel.org
Subject: Re: [PATCH net] ethtool: do not perform operations on net devices being unregistered
Date: Tue, 07 Dec 2021 01:00:09 +0000 [thread overview]
Message-ID: <163883880929.20652.6994089130580113681.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20211203101318.435618-1-atenart@kernel.org>
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 3 Dec 2021 11:13:18 +0100 you wrote:
> There is a short period between a net device starts to be unregistered
> and when it is actually gone. In that time frame ethtool operations
> could still be performed, which might end up in unwanted or undefined
> behaviours[1].
>
> Do not allow ethtool operations after a net device starts its
> unregistration. This patch targets the netlink part as the ioctl one
> isn't affected: the reference to the net device is taken and the
> operation is executed within an rtnl lock section and the net device
> won't be found after unregister.
>
> [...]
Here is the summary with links:
- [net] ethtool: do not perform operations on net devices being unregistered
https://git.kernel.org/netdev/net/c/dde91ccfa25f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-12-07 1:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 10:13 [PATCH net] ethtool: do not perform operations on net devices being unregistered Antoine Tenart
2021-12-06 9:46 ` Julian Wiedmann
2021-12-06 15:15 ` Jakub Kicinski
2021-12-07 8:05 ` Antoine Tenart
2021-12-07 9:05 ` Julian Wiedmann
2021-12-07 1:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163883880929.20652.6994089130580113681.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).