netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: caif: remove redundant assignment to variable expectlen
@ 2021-12-28  0:45 Colin Ian King
  2021-12-28 13:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2021-12-28  0:45 UTC (permalink / raw)
  To: David S . Miller, Jakub Kicinski, netdev; +Cc: kernel-janitors, linux-kernel

Variable expectlen is being assigned a value that is never read, the
assignment occurs before a return statement. The assignment is
redundant and can be removed.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 net/caif/cfserl.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/caif/cfserl.c b/net/caif/cfserl.c
index 40cd57ad0a0f..aee11c74d3c8 100644
--- a/net/caif/cfserl.c
+++ b/net/caif/cfserl.c
@@ -128,7 +128,6 @@ static int cfserl_receive(struct cflayer *l, struct cfpkt *newpkt)
 				if (pkt != NULL)
 					cfpkt_destroy(pkt);
 				layr->incomplete_frm = NULL;
-				expectlen = 0;
 				spin_unlock(&layr->sync);
 				return -EPROTO;
 			}
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: caif: remove redundant assignment to variable expectlen
  2021-12-28  0:45 [PATCH] net: caif: remove redundant assignment to variable expectlen Colin Ian King
@ 2021-12-28 13:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-28 13:00 UTC (permalink / raw)
  To: Colin Ian King; +Cc: davem, kuba, netdev, kernel-janitors, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue, 28 Dec 2021 00:45:42 +0000 you wrote:
> Variable expectlen is being assigned a value that is never read, the
> assignment occurs before a return statement. The assignment is
> redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  net/caif/cfserl.c | 1 -
>  1 file changed, 1 deletion(-)

Here is the summary with links:
  - net: caif: remove redundant assignment to variable expectlen
    https://git.kernel.org/netdev/net-next/c/0f1eae8e565e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-28 13:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-28  0:45 [PATCH] net: caif: remove redundant assignment to variable expectlen Colin Ian King
2021-12-28 13:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).