* [PATCH net-next] net: lantiq_etop: add missing comment for wmb()
@ 2021-12-28 21:49 Aleksander Jan Bajkowski
2021-12-29 0:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Aleksander Jan Bajkowski @ 2021-12-28 21:49 UTC (permalink / raw)
To: davem, kuba, olek2, rdunlap, jgg, arnd, netdev, linux-kernel
This patch adds the missing code comment for memory barrier
call and fixes checkpatch warning:
WARNING: memory barrier without comment
+ wmb();
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
drivers/net/ethernet/lantiq_etop.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index 072391c494ce..5d90cc147950 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
@@ -498,6 +498,7 @@ ltq_etop_tx(struct sk_buff *skb, struct net_device *dev)
spin_lock_irqsave(&priv->lock, flags);
desc->addr = ((unsigned int) dma_map_single(&priv->pdev->dev, skb->data, len,
DMA_TO_DEVICE)) - byte_offset;
+ /* Make sure the address is written before we give it to HW */
wmb();
desc->ctl = LTQ_DMA_OWN | LTQ_DMA_SOP | LTQ_DMA_EOP |
LTQ_DMA_TX_OFFSET(byte_offset) | (len & LTQ_DMA_SIZE_MASK);
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: lantiq_etop: add missing comment for wmb()
2021-12-28 21:49 [PATCH net-next] net: lantiq_etop: add missing comment for wmb() Aleksander Jan Bajkowski
@ 2021-12-29 0:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-29 0:20 UTC (permalink / raw)
To: Aleksander Jan Bajkowski
Cc: davem, kuba, rdunlap, jgg, arnd, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 28 Dec 2021 22:49:10 +0100 you wrote:
> This patch adds the missing code comment for memory barrier
> call and fixes checkpatch warning:
>
> WARNING: memory barrier without comment
> + wmb();
>
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
>
> [...]
Here is the summary with links:
- [net-next] net: lantiq_etop: add missing comment for wmb()
https://git.kernel.org/netdev/net-next/c/723955913e77
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-29 0:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-28 21:49 [PATCH net-next] net: lantiq_etop: add missing comment for wmb() Aleksander Jan Bajkowski
2021-12-29 0:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).