* [PATCH] net: phy: at803x: make array offsets static
@ 2022-01-09 23:17 Colin Ian King
2022-01-10 13:38 ` Andrew Lunn
2022-01-12 5:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2022-01-09 23:17 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, Jakub Kicinski,
netdev
Cc: kernel-janitors, linux-kernel
Don't populate the read-only const array offsets on the stack
but instead make it static. Also makes the object code a little smaller.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/phy/at803x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index dae95d9a07e8..5b6c0d120e09 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -421,7 +421,7 @@ static int at803x_set_wol(struct phy_device *phydev,
const u8 *mac;
int ret, irq_enabled;
unsigned int i;
- const unsigned int offsets[] = {
+ static const unsigned int offsets[] = {
AT803X_LOC_MAC_ADDR_32_47_OFFSET,
AT803X_LOC_MAC_ADDR_16_31_OFFSET,
AT803X_LOC_MAC_ADDR_0_15_OFFSET,
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: phy: at803x: make array offsets static
2022-01-09 23:17 [PATCH] net: phy: at803x: make array offsets static Colin Ian King
@ 2022-01-10 13:38 ` Andrew Lunn
2022-01-12 5:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2022-01-10 13:38 UTC (permalink / raw)
To: Colin Ian King
Cc: Heiner Kallweit, Russell King, Jakub Kicinski, netdev,
kernel-janitors, linux-kernel
On Sun, Jan 09, 2022 at 11:17:16PM +0000, Colin Ian King wrote:
> Don't populate the read-only const array offsets on the stack
> but instead make it static. Also makes the object code a little smaller.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: phy: at803x: make array offsets static
2022-01-09 23:17 [PATCH] net: phy: at803x: make array offsets static Colin Ian King
2022-01-10 13:38 ` Andrew Lunn
@ 2022-01-12 5:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-01-12 5:20 UTC (permalink / raw)
To: Colin Ian King
Cc: andrew, hkallweit1, linux, kuba, netdev, kernel-janitors,
linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 9 Jan 2022 23:17:16 +0000 you wrote:
> Don't populate the read-only const array offsets on the stack
> but instead make it static. Also makes the object code a little smaller.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/net/phy/at803x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- net: phy: at803x: make array offsets static
https://git.kernel.org/netdev/net/c/edcb501e543c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-12 5:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-09 23:17 [PATCH] net: phy: at803x: make array offsets static Colin Ian King
2022-01-10 13:38 ` Andrew Lunn
2022-01-12 5:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).