From: Raag Jadav <raagjadav@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Steen Hegelund <steen.hegelund@microchip.com>,
Bjarni Jonasson <bjarni.jonasson@microchip.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Raag Jadav <raagjadav@gmail.com>
Subject: [PATCH] net: phy: mscc: enable MAC SerDes autonegotiation
Date: Sat, 5 Feb 2022 12:14:52 +0530 [thread overview]
Message-ID: <1644043492-31307-1-git-send-email-raagjadav@gmail.com> (raw)
Enable MAC SerDes autonegotiation to distinguish between
1000BASE-X, SGMII and QSGMII MAC.
Signed-off-by: Raag Jadav <raagjadav@gmail.com>
---
drivers/net/phy/mscc/mscc.h | 2 ++
drivers/net/phy/mscc/mscc_main.c | 24 ++++++++++++++++++++++++
2 files changed, 26 insertions(+)
diff --git a/drivers/net/phy/mscc/mscc.h b/drivers/net/phy/mscc/mscc.h
index a50235f..366db14 100644
--- a/drivers/net/phy/mscc/mscc.h
+++ b/drivers/net/phy/mscc/mscc.h
@@ -195,6 +195,8 @@ enum rgmii_clock_delay {
#define MSCC_PHY_EXTENDED_INT_MS_EGR BIT(9)
/* Extended Page 3 Registers */
+#define MSCC_PHY_SERDES_PCS_CTRL 16
+#define MSCC_PHY_SERDES_ANEG BIT(7)
#define MSCC_PHY_SERDES_TX_VALID_CNT 21
#define MSCC_PHY_SERDES_TX_CRC_ERR_CNT 22
#define MSCC_PHY_SERDES_RX_VALID_CNT 28
diff --git a/drivers/net/phy/mscc/mscc_main.c b/drivers/net/phy/mscc/mscc_main.c
index ebfeeb3..6db43a5 100644
--- a/drivers/net/phy/mscc/mscc_main.c
+++ b/drivers/net/phy/mscc/mscc_main.c
@@ -1685,6 +1685,25 @@ static int vsc8574_config_host_serdes(struct phy_device *phydev)
PROC_CMD_RST_CONF_PORT | PROC_CMD_FIBER_1000BASE_X);
}
+static int vsc85xx_config_inband_aneg(struct phy_device *phydev, bool enabled)
+{
+ int rc;
+ u16 reg_val = 0;
+
+ if (enabled)
+ reg_val = MSCC_PHY_SERDES_ANEG;
+
+ mutex_lock(&phydev->lock);
+
+ rc = phy_modify_paged(phydev, MSCC_PHY_PAGE_EXTENDED_3,
+ MSCC_PHY_SERDES_PCS_CTRL, MSCC_PHY_SERDES_ANEG,
+ reg_val);
+
+ mutex_unlock(&phydev->lock);
+
+ return rc;
+}
+
static int vsc8584_config_init(struct phy_device *phydev)
{
struct vsc8531_private *vsc8531 = phydev->priv;
@@ -1772,6 +1791,11 @@ static int vsc8584_config_init(struct phy_device *phydev)
VSC8572_RGMII_TX_DELAY_MASK);
if (ret)
return ret;
+ } else {
+ /* Enable clause 37 */
+ ret = vsc85xx_config_inband_aneg(phydev, true);
+ if (ret)
+ return ret;
}
ret = genphy_soft_reset(phydev);
--
2.7.4
next reply other threads:[~2022-02-05 6:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-05 6:44 Raag Jadav [this message]
2022-02-05 14:57 ` [PATCH] net: phy: mscc: enable MAC SerDes autonegotiation Andrew Lunn
2022-02-06 17:12 ` Raag Jadav
2022-02-06 17:18 ` Russell King (Oracle)
2022-02-06 18:01 ` Andrew Lunn
2022-02-07 17:49 ` Raag Jadav
2022-02-08 2:09 ` Andrew Lunn
2022-02-08 15:57 ` Raag Jadav
2022-02-08 16:01 ` Russell King (Oracle)
2022-02-08 19:12 ` Andrew Lunn
2022-02-10 16:48 ` Raag Jadav
2022-02-08 9:45 ` Russell King (Oracle)
2022-02-08 15:53 ` Raag Jadav
2022-02-24 10:41 ` Siddharth Narayan Vadapalli
2022-02-24 10:48 ` Russell King (Oracle)
2022-02-26 7:23 ` Raag Jadav
2022-02-26 16:31 ` Russell King (Oracle)
2022-03-27 8:32 ` Raag Jadav
2022-03-24 10:06 ` Siddharth Vadapalli
2022-03-27 8:30 ` Raag Jadav
2022-03-28 8:13 ` Siddharth Vadapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1644043492-31307-1-git-send-email-raagjadav@gmail.com \
--to=raagjadav@gmail.com \
--cc=andrew@lunn.ch \
--cc=bjarni.jonasson@microchip.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=steen.hegelund@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).