* [PATCH net-next v2] net: lan966x: Fix when CONFIG_IPV6 is not set
@ 2022-02-12 20:03 Horatiu Vultur
2022-02-13 16:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Horatiu Vultur @ 2022-02-12 20:03 UTC (permalink / raw)
To: netdev, linux-kernel
Cc: UNGLinuxDriver, davem, kuba, andrew, Horatiu Vultur,
kernel test robot
When CONFIG_IPV6 is not set, then the linking of the lan966x driver
fails with the following error:
drivers/net/ethernet/microchip/lan966x/lan966x_main.c:444: undefined
reference to `ipv6_mc_check_mld'
The fix consists in adding a check also for IS_ENABLED(CONFIG_IPV6)
Fixes: 47aeea0d57e80c ("net: lan966x: Implement the callback SWITCHDEV_ATTR_ID_BRIDGE_MC_DISABLED")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
v1->v2:
- use IS_ENABLED(CONFIG_IPV6) instead of #ifdef
---
drivers/net/ethernet/microchip/lan966x/lan966x_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
index d62484f14564..4e877d9859bf 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
@@ -439,7 +439,8 @@ static bool lan966x_hw_offload(struct lan966x *lan966x, u32 port,
ip_hdr(skb)->protocol == IPPROTO_IGMP)
return false;
- if (skb->protocol == htons(ETH_P_IPV6) &&
+ if (IS_ENABLED(CONFIG_IPV6) &&
+ skb->protocol == htons(ETH_P_IPV6) &&
ipv6_addr_is_multicast(&ipv6_hdr(skb)->daddr) &&
!ipv6_mc_check_mld(skb))
return false;
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next v2] net: lan966x: Fix when CONFIG_IPV6 is not set
2022-02-12 20:03 [PATCH net-next v2] net: lan966x: Fix when CONFIG_IPV6 is not set Horatiu Vultur
@ 2022-02-13 16:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-02-13 16:00 UTC (permalink / raw)
To: Horatiu Vultur
Cc: netdev, linux-kernel, UNGLinuxDriver, davem, kuba, andrew, lkp
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Sat, 12 Feb 2022 21:03:43 +0100 you wrote:
> When CONFIG_IPV6 is not set, then the linking of the lan966x driver
> fails with the following error:
>
> drivers/net/ethernet/microchip/lan966x/lan966x_main.c:444: undefined
> reference to `ipv6_mc_check_mld'
>
> The fix consists in adding a check also for IS_ENABLED(CONFIG_IPV6)
>
> [...]
Here is the summary with links:
- [net-next,v2] net: lan966x: Fix when CONFIG_IPV6 is not set
https://git.kernel.org/netdev/net-next/c/867b1db874c9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-13 16:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-12 20:03 [PATCH net-next v2] net: lan966x: Fix when CONFIG_IPV6 is not set Horatiu Vultur
2022-02-13 16:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).