From: Michael Richardson <mcr@sandelman.ottawa.on.ca>
To: Patrick McHardy <kaber@trash.net>
Cc: kuznet@ms2.inr.ac.ru,
netfilter-devel <netfilter-devel@lists.netfilter.org>,
Jamal Hadi Salim <hadi@cyberus.ca>,
netdev@vger.kernel.org
Subject: Re: [PATCH 02/02] add mask options to fwmark masking code
Date: Thu, 23 Feb 2006 14:36:58 -0500 [thread overview]
Message-ID: <16464.1140723418@sandelman.ottawa.on.ca> (raw)
In-Reply-To: Message from Patrick McHardy <kaber@trash.net> of "Mon, 20 Feb 2006 17:57:11 +0100." <43F9F4E7.5000708@trash.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
>>>>> "Patrick" == Patrick McHardy <kaber@trash.net> writes:
>> #define RTA_FWMARK RTA_PROTOINFO +#define RTA_FWMARK_MASK
>> RTA_CACHEINFO
Patrick> Please introduce a new attribute for this instead of
Patrick> overloading RTA_CACHEINFO.
I would be happy to do that.
Should I also un-overload FWMARK, with backwards compatibility?
>> diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c index
>> de327b3..69eed89 100644 --- a/net/ipv4/fib_rules.c +++
>> b/net/ipv4/fib_rules.c @@ -68,6 +68,7 @@ struct fib_rule u8
>> r_tos; #ifdef CONFIG_IP_ROUTE_FWMARK u32 r_fwmark; + u32
>> r_fwmark_mask;
Patrick> Both patches have whitespace issues. You should also change
uhm. okay.
I'm surprised, since I produced it with git-format-patch. Maybe there
are tabs that emacs screwed up.
- --
] ON HUMILITY: to err is human. To moo, bovine. | firewalls [
] Michael Richardson, Xelerance Corporation, Ottawa, ON |net architect[
] mcr@xelerance.com http://www.sandelman.ottawa.on.ca/mcr/ |device driver[
] panic("Just another Debian GNU/Linux using, kernel hacking, security guy"); [
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Finger me for keys
iQEVAwUBQ/4O2ICLcPvd0N1lAQK/egf6A0iQ1hvecR4BeaCrQiu53beGZd6zHldk
o6logfar94kPP/H/D/kMcNeAvL2a3cJ8wyfyP02Cav8gP1C3X+XV+yLtA9jHIrdK
nqQ1gw7F4Cj2+v7du/jS8GxNMWevXhJ7f9hvnzh8+DHMUCjqiksgsuIgcRQYrqOQ
vxYERvR5TojEIaJfg8kH/lJRn3sm/APuMphM6c6SAeqrWpAdijbZb4LSNpGH50ci
nNhUp+FxoP8vVFTMTu7M1MK4fpCIWA/PxBkmy3YDhcQx1+mE2nrEqHdbKfx9uY+t
0mxR8UC5sthhn94/VCjcqWOoHe3S/Gi+WWoPtwN1sFe5BujwU7Vcfw==
=yKIA
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2006-02-23 19:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-20 16:26 [PATCH 02/02] add mask options to fwmark masking code Michael Richardson
2006-02-20 16:57 ` Patrick McHardy
2006-02-23 19:36 ` Michael Richardson [this message]
2006-02-24 4:58 ` Patrick McHardy
2006-02-20 17:16 ` Patrick McHardy
2006-02-20 19:58 ` Carl-Daniel Hailfinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16464.1140723418@sandelman.ottawa.on.ca \
--to=mcr@sandelman.ottawa.on.ca \
--cc=hadi@cyberus.ca \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).