From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD25EC4321E for ; Wed, 9 Mar 2022 09:28:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232067AbiCIJ3K (ORCPT ); Wed, 9 Mar 2022 04:29:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231328AbiCIJ3J (ORCPT ); Wed, 9 Mar 2022 04:29:09 -0500 Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C90D4C6235; Wed, 9 Mar 2022 01:28:09 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R711e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=33;SR=0;TI=SMTPD_---0V6j5umZ_1646818083; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0V6j5umZ_1646818083) by smtp.aliyun-inc.com(127.0.0.1); Wed, 09 Mar 2022 17:28:04 +0800 Message-ID: <1646818039.8335996-8-xuanzhuo@linux.alibaba.com> Subject: Re: [PATCH v7 14/26] virtio: add helper for queue reset Date: Wed, 9 Mar 2022 17:27:19 +0800 From: Xuan Zhuo To: Jason Wang Cc: Jeff Dike , Richard Weinberger , Anton Ivanov , "Michael S. Tsirkin" , "David S. Miller" , Jakub Kicinski , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Johannes Berg , Vincent Whitchurch , linux-um@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org References: <20220308123518.33800-1-xuanzhuo@linux.alibaba.com> <20220308123518.33800-15-xuanzhuo@linux.alibaba.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 9 Mar 2022 16:48:28 +0800, Jason Wang wrote: > > =E5=9C=A8 2022/3/8 =E4=B8=8B=E5=8D=888:35, Xuan Zhuo =E5=86=99=E9=81=93: > > Add helper for virtio queue reset. > > > > * virtio_reset_vq(): reset a queue individually > > * virtio_enable_resetq(): enable a reset queue > > > > Signed-off-by: Xuan Zhuo > > --- > > include/linux/virtio_config.h | 40 +++++++++++++++++++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > > > diff --git a/include/linux/virtio_config.h b/include/linux/virtio_confi= g.h > > index d51906b1389f..0b81fbe17c85 100644 > > --- a/include/linux/virtio_config.h > > +++ b/include/linux/virtio_config.h > > @@ -230,6 +230,46 @@ int virtio_find_vqs_ctx(struct virtio_device *vdev= , unsigned nvqs, > > desc); > > } > > > > +/** > > + * virtio_reset_vq - reset a queue individually > > + * @vq: the virtqueue > > + * > > + * returns 0 on success or error status > > + * > > + * The api process of reset under normal circumstances: > > + * 1. virtio_reset_vq() - notify the device to reset the = queue > > + * 2. virtqueue_detach_unused_buf() - recycle the buffer submitted > > + * 3. virtqueue_reset_vring() - reset the vring (may re-alloc) > > + * 4. virtio_enable_resetq() - mmap vring to device, and enabl= e the queue > > + * > > + * Caller should guarantee that the vring is not accessed by any funct= ions > > + * of virtqueue. > > + */ > > +static inline > > +int virtio_reset_vq(struct virtqueue *vq) > > +{ > > > It looks to me the prefix "virtio" is used for the device specific > operations. > > I wonder if it's better to rename this as virtqueue_reste() and move it > to virtio_ring.c? Call vq->vdev->config->reset_vq in virtio_ring.c? If it fits, I think it's fine. Thanks. > > Thanks > > > > + if (!vq->vdev->config->reset_vq) > > + return -ENOENT; > > + > > + return vq->vdev->config->reset_vq(vq); > > +} > > + > > +/** > > + * virtio_enable_resetq - enable a reset queue > > + * @vq: the virtqueue > > + * > > + * returns 0 on success or error status > > + * > > + */ > > +static inline > > +int virtio_enable_resetq(struct virtqueue *vq) > > +{ > > + if (!vq->vdev->config->enable_reset_vq) > > + return -ENOENT; > > + > > + return vq->vdev->config->enable_reset_vq(vq); > > +} > > + > > /** > > * virtio_device_ready - enable vq use in probe function > > * @vdev: the device >