From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 084D0C4321E for ; Wed, 9 Mar 2022 10:00:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232365AbiCIKA5 (ORCPT ); Wed, 9 Mar 2022 05:00:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231266AbiCIKAz (ORCPT ); Wed, 9 Mar 2022 05:00:55 -0500 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE7FF16F970; Wed, 9 Mar 2022 01:59:55 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R231e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=33;SR=0;TI=SMTPD_---0V6jAtL._1646819988; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0V6jAtL._1646819988) by smtp.aliyun-inc.com(127.0.0.1); Wed, 09 Mar 2022 17:59:49 +0800 Message-ID: <1646819926.6046128-13-xuanzhuo@linux.alibaba.com> Subject: Re: [PATCH v7 21/26] virtio: add helper virtio_find_vqs_ctx_size() Date: Wed, 9 Mar 2022 17:58:46 +0800 From: Xuan Zhuo To: Jason Wang Cc: Jeff Dike , Richard Weinberger , Anton Ivanov , "Michael S. Tsirkin" , "David S. Miller" , Jakub Kicinski , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Johannes Berg , Vincent Whitchurch , linux-um@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org References: <20220308123518.33800-1-xuanzhuo@linux.alibaba.com> <20220308123518.33800-22-xuanzhuo@linux.alibaba.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 9 Mar 2022 17:04:12 +0800, Jason Wang wrote: > > =E5=9C=A8 2022/3/8 =E4=B8=8B=E5=8D=888:35, Xuan Zhuo =E5=86=99=E9=81=93: > > Introduce helper virtio_find_vqs_ctx_size() to call find_vqs and specify > > the maximum size of each vq ring. > > > > Signed-off-by: Xuan Zhuo > > --- > > include/linux/virtio_config.h | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/include/linux/virtio_config.h b/include/linux/virtio_confi= g.h > > index 5157524d8036..921d8610db0c 100644 > > --- a/include/linux/virtio_config.h > > +++ b/include/linux/virtio_config.h > > @@ -233,6 +233,18 @@ int virtio_find_vqs_ctx(struct virtio_device *vdev= , unsigned nvqs, > > desc, NULL); > > } > > > > +static inline > > +int virtio_find_vqs_ctx_size(struct virtio_device *vdev, u32 nvqs, > > + struct virtqueue *vqs[], > > + vq_callback_t *callbacks[], > > + const char * const names[], > > + const bool *ctx, struct irq_affinity *desc, > > + u32 sizes[]) > > +{ > > + return vdev->config->find_vqs(vdev, nvqs, vqs, callbacks, names, ctx, > > + desc, sizes); > > +} > > > Do we need to convert all the open coded direct call to find_vqs() other > than net? Do you mean calling find_vqs without a helper? The kernel doesn't do that anymore. Thanks. > > Thanks > > > > + > > /** > > * virtio_reset_vq - reset a queue individually > > * @vq: the virtqueue >