* [PATCH] net: phy: DP83822: clear MISR2 register to disable interrupts
@ 2022-03-09 14:22 Clément Léger
2022-03-09 16:48 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Clément Léger @ 2022-03-09 14:22 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, David S . Miller,
Jakub Kicinski, Florian Fainelli, Andrew F . Davis, Dan Murphy
Cc: netdev, linux-kernel, Thomas Petazzoni, Miquel Raynal,
Clément Léger
MISR1 was cleared twice but the original author intention was probably
to clear MISR1 & MISR2 to completely disable interrupts. Fix it to
clear MISR2.
Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
---
drivers/net/phy/dp83822.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index 211b5476a6f5..ce17b2af3218 100644
--- a/drivers/net/phy/dp83822.c
+++ b/drivers/net/phy/dp83822.c
@@ -274,7 +274,7 @@ static int dp83822_config_intr(struct phy_device *phydev)
if (err < 0)
return err;
- err = phy_write(phydev, MII_DP83822_MISR1, 0);
+ err = phy_write(phydev, MII_DP83822_MISR2, 0);
if (err < 0)
return err;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] net: phy: DP83822: clear MISR2 register to disable interrupts
2022-03-09 14:22 [PATCH] net: phy: DP83822: clear MISR2 register to disable interrupts Clément Léger
@ 2022-03-09 16:48 ` Andrew Lunn
2022-03-09 17:40 ` Florian Fainelli
2022-03-10 20:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2022-03-09 16:48 UTC (permalink / raw)
To: Clément Léger
Cc: Heiner Kallweit, Russell King, David S . Miller, Jakub Kicinski,
Florian Fainelli, Andrew F . Davis, Dan Murphy, netdev,
linux-kernel, Thomas Petazzoni, Miquel Raynal
On Wed, Mar 09, 2022 at 03:22:28PM +0100, Clément Léger wrote:
> MISR1 was cleared twice but the original author intention was probably
> to clear MISR1 & MISR2 to completely disable interrupts. Fix it to
> clear MISR2.
>
> Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: phy: DP83822: clear MISR2 register to disable interrupts
2022-03-09 14:22 [PATCH] net: phy: DP83822: clear MISR2 register to disable interrupts Clément Léger
2022-03-09 16:48 ` Andrew Lunn
@ 2022-03-09 17:40 ` Florian Fainelli
2022-03-10 20:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2022-03-09 17:40 UTC (permalink / raw)
To: Clément Léger, Andrew Lunn, Heiner Kallweit,
Russell King, David S . Miller, Jakub Kicinski, Andrew F . Davis,
Dan Murphy
Cc: netdev, linux-kernel, Thomas Petazzoni, Miquel Raynal
On 3/9/22 6:22 AM, Clément Léger wrote:
> MISR1 was cleared twice but the original author intention was probably
> to clear MISR1 & MISR2 to completely disable interrupts. Fix it to
> clear MISR2.
>
> Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: phy: DP83822: clear MISR2 register to disable interrupts
2022-03-09 14:22 [PATCH] net: phy: DP83822: clear MISR2 register to disable interrupts Clément Léger
2022-03-09 16:48 ` Andrew Lunn
2022-03-09 17:40 ` Florian Fainelli
@ 2022-03-10 20:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-10 20:40 UTC (permalink / raw)
To: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2VyIDxjbGVtZW50LmxlZ2VyQGJvb3RsaW4uY29tPg==?=
Cc: andrew, hkallweit1, linux, davem, kuba, f.fainelli, afd, dmurphy,
netdev, linux-kernel, thomas.petazzoni, miquel.raynal
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 9 Mar 2022 15:22:28 +0100 you wrote:
> MISR1 was cleared twice but the original author intention was probably
> to clear MISR1 & MISR2 to completely disable interrupts. Fix it to
> clear MISR2.
>
> Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
>
> [...]
Here is the summary with links:
- net: phy: DP83822: clear MISR2 register to disable interrupts
https://git.kernel.org/netdev/net/c/37c9d66c9556
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-10 20:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-09 14:22 [PATCH] net: phy: DP83822: clear MISR2 register to disable interrupts Clément Léger
2022-03-09 16:48 ` Andrew Lunn
2022-03-09 17:40 ` Florian Fainelli
2022-03-10 20:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).