From: patchwork-bot+netdevbpf@kernel.org
To: Namhyung Kim <namhyung@kernel.org>
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, acme@kernel.org,
peterz@infradead.org, eugene.loh@oracle.com, haoluo@google.com
Subject: Re: [PATCH v3 1/2] bpf: Adjust BPF stack helper functions to accommodate skip > 0
Date: Mon, 21 Mar 2022 02:30:10 +0000 [thread overview]
Message-ID: <164782981040.13314.15450443324560487136.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220314182042.71025-1-namhyung@kernel.org>
Hello:
This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Mon, 14 Mar 2022 11:20:41 -0700 you wrote:
> Let's say that the caller has storage for num_elem stack frames. Then,
> the BPF stack helper functions walk the stack for only num_elem frames.
> This means that if skip > 0, one keeps only 'num_elem - skip' frames.
>
> This is because it sets init_nr in the perf_callchain_entry to the end
> of the buffer to save num_elem entries only. I believe it was because
> the perf callchain code unwound the stack frames until it reached the
> global max size (sysctl_perf_event_max_stack).
>
> [...]
Here is the summary with links:
- [v3,1/2] bpf: Adjust BPF stack helper functions to accommodate skip > 0
https://git.kernel.org/bpf/bpf-next/c/ee2a098851bf
- [v3,2/2] bpf/selftests: Test skipping stacktrace
https://git.kernel.org/bpf/bpf-next/c/e1cc1f39981b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-03-21 2:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 18:20 [PATCH v3 1/2] bpf: Adjust BPF stack helper functions to accommodate skip > 0 Namhyung Kim
2022-03-14 18:20 ` [PATCH v3 2/2] bpf/selftests: Test skipping stacktrace Namhyung Kim
2022-03-15 5:18 ` Yonghong Song
2022-03-21 2:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164782981040.13314.15450443324560487136.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eugene.loh@oracle.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).