Re: [PATCH net-next v8 2/3] net: ti: icssm-prueth: Add switchdev support for icssm_prueth driver

Parvathi Pudi
2025-12-03T08:38:18Z

Hi,

> On Wed, 26 Nov 2025 21:57:13 +0530 Parvathi Pudi wrote:
>> + */
>> +static void icssm_prueth_sw_switchdev_event_work(struct work_struct *work)
>> +{
>> + struct icssm_prueth_sw_switchdev_event_work *switchdev_work =
>> + container_of(work,
>> + struct icssm_prueth_sw_switchdev_event_work, work);
>
> Consider using shorter type names.
>

We will address this in the next version.

>> + struct prueth_emac *emac = switchdev_work->emac;
>> + struct switchdev_notifier_fdb_info *fdb;
>> + struct prueth *prueth = emac->prueth;
>> + int port = emac->port_id;
>> +
>> + rtnl_lock();
>> +
>> + /* Interface is not up */
>> + if (!emac->prueth->fdb_tbl) {
>> + rtnl_unlock();
>
> Are you not leaking the device reference here?
>

We will address this in the next version.

Thanks and Regards,
Parvathi.