From: patchwork-bot+netdevbpf@kernel.org
To: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Cc: f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com,
olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: dsa: bcm_sf2_cfp: fix an incorrect NULL check on list iterator
Date: Mon, 28 Mar 2022 23:30:12 +0000 [thread overview]
Message-ID: <164851021200.6043.5974433550480970783.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220328032431.22538-1-xiam0nd.tong@gmail.com>
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 28 Mar 2022 11:24:31 +0800 you wrote:
> The bug is here:
> return rule;
>
> The list iterator value 'rule' will *always* be set and non-NULL
> by list_for_each_entry(), so it is incorrect to assume that the
> iterator value will be NULL if the list is empty or no element
> is found.
>
> [...]
Here is the summary with links:
- net: dsa: bcm_sf2_cfp: fix an incorrect NULL check on list iterator
https://git.kernel.org/netdev/net/c/6da69b1da130
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-03-28 23:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 3:24 [PATCH] net: dsa: bcm_sf2_cfp: fix an incorrect NULL check on list iterator Xiaomeng Tong
2022-03-28 23:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164851021200.6043.5974433550480970783.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
--cc=xiam0nd.tong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).