* [PATCH] net: micrel: fix KS8851_MLL Kconfig
@ 2022-04-01 5:42 Randy Dunlap
2022-04-01 11:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2022-04-01 5:42 UTC (permalink / raw)
To: netdev; +Cc: patches, Randy Dunlap, David S. Miller, Jakub Kicinski,
Paolo Abeni
KS8851_MLL selects MICREL_PHY, which depends on PTP_1588_CLOCK_OPTIONAL,
so make KS8851_MLL also depend on PTP_1588_CLOCK_OPTIONAL since
'select' does not follow any dependency chains.
Fixes kconfig warning and build errors:
WARNING: unmet direct dependencies detected for MICREL_PHY
Depends on [m]: NETDEVICES [=y] && PHYLIB [=y] && PTP_1588_CLOCK_OPTIONAL [=m]
Selected by [y]:
- KS8851_MLL [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICREL [=y] && HAS_IOMEM [=y]
ld: drivers/net/phy/micrel.o: in function `lan8814_ts_info':
micrel.c:(.text+0xb35): undefined reference to `ptp_clock_index'
ld: drivers/net/phy/micrel.o: in function `lan8814_probe':
micrel.c:(.text+0x2586): undefined reference to `ptp_clock_register'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
---
drivers/net/ethernet/micrel/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- mmotm-2022-0331-2037.orig/drivers/net/ethernet/micrel/Kconfig
+++ mmotm-2022-0331-2037/drivers/net/ethernet/micrel/Kconfig
@@ -39,6 +39,7 @@ config KS8851
config KS8851_MLL
tristate "Micrel KS8851 MLL"
depends on HAS_IOMEM
+ depends on PTP_1588_CLOCK_OPTIONAL
select MII
select CRC32
select EEPROM_93CX6
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net: micrel: fix KS8851_MLL Kconfig
2022-04-01 5:42 [PATCH] net: micrel: fix KS8851_MLL Kconfig Randy Dunlap
@ 2022-04-01 11:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-04-01 11:10 UTC (permalink / raw)
To: Randy Dunlap; +Cc: netdev, patches, davem, kuba, pabeni
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 31 Mar 2022 22:42:44 -0700 you wrote:
> KS8851_MLL selects MICREL_PHY, which depends on PTP_1588_CLOCK_OPTIONAL,
> so make KS8851_MLL also depend on PTP_1588_CLOCK_OPTIONAL since
> 'select' does not follow any dependency chains.
>
> Fixes kconfig warning and build errors:
>
> WARNING: unmet direct dependencies detected for MICREL_PHY
> Depends on [m]: NETDEVICES [=y] && PHYLIB [=y] && PTP_1588_CLOCK_OPTIONAL [=m]
> Selected by [y]:
> - KS8851_MLL [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICREL [=y] && HAS_IOMEM [=y]
>
> [...]
Here is the summary with links:
- net: micrel: fix KS8851_MLL Kconfig
https://git.kernel.org/netdev/net/c/c3efcedd272a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-01 11:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-01 5:42 [PATCH] net: micrel: fix KS8851_MLL Kconfig Randy Dunlap
2022-04-01 11:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).