* [PATCH RESEND] net: usb: remove duplicate assignment
@ 2022-04-06 9:17 Qing Wang
2022-04-06 14:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Qing Wang @ 2022-04-06 9:17 UTC (permalink / raw)
To: Bjørn Mork, David S. Miller, Jakub Kicinski, netdev,
linux-usb, linux-kernel
Cc: Wang Qing
From: Wang Qing <wangqing@vivo.com>
netdev_alloc_skb() has assigned ssi->netdev to skb->dev if successed,
no need to repeat assignment.
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
drivers/net/usb/qmi_wwan.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 3353e76..17cf0d1
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -190,7 +190,6 @@ static int qmimux_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
skbn = netdev_alloc_skb(net, pkt_len + LL_MAX_HEADER);
if (!skbn)
return 0;
- skbn->dev = net;
switch (skb->data[offset + qmimux_hdr_sz] & 0xf0) {
case 0x40:
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] net: usb: remove duplicate assignment
2022-04-06 9:17 [PATCH RESEND] net: usb: remove duplicate assignment Qing Wang
@ 2022-04-06 14:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-04-06 14:30 UTC (permalink / raw)
To: Qing Wang; +Cc: bjorn, davem, kuba, netdev, linux-usb, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 6 Apr 2022 02:17:03 -0700 you wrote:
> From: Wang Qing <wangqing@vivo.com>
>
> netdev_alloc_skb() has assigned ssi->netdev to skb->dev if successed,
> no need to repeat assignment.
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
>
> [...]
Here is the summary with links:
- [RESEND] net: usb: remove duplicate assignment
https://git.kernel.org/netdev/net-next/c/207d924dcf32
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-06 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-06 9:17 [PATCH RESEND] net: usb: remove duplicate assignment Qing Wang
2022-04-06 14:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).