From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 152E5C4332F for ; Tue, 12 Apr 2022 13:37:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240889AbiDLNjx (ORCPT ); Tue, 12 Apr 2022 09:39:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234919AbiDLNju (ORCPT ); Tue, 12 Apr 2022 09:39:50 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D9762E092; Tue, 12 Apr 2022 06:37:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4B9DCB81D7A; Tue, 12 Apr 2022 13:37:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 857E1C385A1; Tue, 12 Apr 2022 13:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649770649; bh=v0nDaaCQ3usmsYxnhE/FHNZck2HIGICmWaiMBdencwI=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Uk22QgIvlCLGqhttJUlJHTKFNSZX3+X8U3p7zjNDrYvQZ51Q+P+X/ad8ErHVMVOVB AbsreyM2rucCIm8k3sOR9v5RGUoilV/1m6IzSXvTJ5VW+WDsOrwwC61nkO+ItW/MSV 23oD+7nfadTQw0idWgv8adiHLZGLOanERg0NgFEHS2ODvDLmfhqqVe3jpVVHccqGts JIkq8FvcNzgNVvGqIDsMdr09ViFum4BZiR55Zq672PyUeOAJDUURNLOf3RkCKAiX44 geNC39ZapXVaX88pE0H4QQ66mC9DgYk8RMs6nV0vuKqKnhEF8zpmInujfPFmMs+0L+ 8cjrQNJwae/vQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtw89: ser: add a break statement From: Kalle Valo In-Reply-To: <20220407175349.3053362-1-trix@redhat.com> References: <20220407175349.3053362-1-trix@redhat.com> To: Tom Rix Cc: pkshih@realtek.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, nathan@kernel.org, ndesaulniers@google.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <164977064177.31115.17806762798615887989.kvalo@kernel.org> Date: Tue, 12 Apr 2022 13:37:26 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tom Rix wrote: > The clang build fails with > ser.c:397:2: error: unannotated fall-through > between switch labels [-Werror,-Wimplicit-fallthrough] > default: > ^ > The case above the default does not have a break. > So add one. > > Signed-off-by: Tom Rix > Reviewed-by: Nathan Chancellor I took Zong's version: https://patchwork.kernel.org/project/linux-wireless/patch/20220408001353.17188-2-pkshih@realtek.com/ Patch set to Superseded. -- https://patchwork.kernel.org/project/linux-wireless/patch/20220407175349.3053362-1-trix@redhat.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches