From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A294C433FE for ; Fri, 15 Apr 2022 11:00:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352521AbiDOLCn (ORCPT ); Fri, 15 Apr 2022 07:02:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242219AbiDOLCl (ORCPT ); Fri, 15 Apr 2022 07:02:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3282E68988; Fri, 15 Apr 2022 04:00:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BC60762254; Fri, 15 Apr 2022 11:00:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 11491C385A9; Fri, 15 Apr 2022 11:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650020412; bh=xxBLbG0zk2w7QvaLqimPElzowCyAGhDvRmaAMz/60t0=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=SYtF4cEe5XvMnLtsbqvbHcYiXnOC9adriRy5ewJjV+133VB1KMPB6duI/vLlBtMP7 fK4JoRu8q0jB0NfakMIQnfv6hfKbg4ISiATywQ+SBWBadTApjIA6FwX/UTJiYTCRIb /0XMqnZqpMMzE03ggpnOEXWtNjOlvTW3by0WuFSNnzssN90WmWPkliURPuxOCWyCVi TXXBw41f/O+S/8JYnkzj+dIigWgrrbSXXcnYqtXqfDr+HCY9H94DObJT2JoXQpMmgl 3O13vizizRRqR+Z7EFlNBQ8dlTuhrhVWcGYo+11QIA6TvuxiwpUxWOfqp/xI+PViLh axlIlw+g0UINQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id E93BCEAC096; Fri, 15 Apr 2022 11:00:11 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] openvswitch: fix OOB access in reserve_sfa_size() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165002041195.31119.1787204270589616559.git-patchwork-notify@kernel.org> Date: Fri, 15 Apr 2022 11:00:11 +0000 References: <165001012108.2147631.5880395764325229829.stgit@fed.void> In-Reply-To: <165001012108.2147631.5880395764325229829.stgit@fed.void> To: Paolo Valerio Cc: netdev@vger.kernel.org, dev@openvswitch.org, pshelar@ovn.org, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, stable@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 15 Apr 2022 10:08:41 +0200 you wrote: > Given a sufficiently large number of actions, while copying and > reserving memory for a new action of a new flow, if next_offset is > greater than MAX_ACTIONS_BUFSIZE, the function reserve_sfa_size() does > not return -EMSGSIZE as expected, but it allocates MAX_ACTIONS_BUFSIZE > bytes increasing actions_len by req_size. This can then lead to an OOB > write access, especially when further actions need to be copied. > > [...] Here is the summary with links: - openvswitch: fix OOB access in reserve_sfa_size() https://git.kernel.org/netdev/net/c/cefa91b2332d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html