[PATCH net-next v4] selftests: net: vrf_strict_mode_test: add support to select a test to run

[PATCH net-next v4] selftests: net: vrf_strict_mode_test: add support to select a test to run

[Jaehee Park]

Add a boilerplate test loop to run all tests in
vrf_strict_mode_test.sh. Add a -t flag that allows a selected test to
run. Remove the vrf_strict_mode_tests function which is now unused.

Signed-off-by: Jaehee Park <jhpark1013@gmail.com>
---
v2 
- Add a -t flag that allows a selected test to
run.

v3 
- Add commented delineators to section the code for improved
readability.
- Move the log_section() call into the functions handling the tests.
- Remove unnecessary spaces.

v4 
- Remove unused function
- Edit the patch log to reflect this change.


 .../selftests/net/vrf_strict_mode_test.sh     | 48 +++++++++++++++----
 1 file changed, 39 insertions(+), 9 deletions(-)

diff --git a/tools/testing/selftests/net/vrf_strict_mode_test.sh b/tools/testing/selftests/net/vrf_strict_mode_test.sh
index 865d53c1781c..417d214264f3 100755
--- a/tools/testing/selftests/net/vrf_strict_mode_test.sh
+++ b/tools/testing/selftests/net/vrf_strict_mode_test.sh
@@ -14,6 +14,8 @@ INIT_NETNS_NAME="init"
 
 PAUSE_ON_FAIL=${PAUSE_ON_FAIL:=no}
 
+TESTS="init testns mix"
+
 log_test()
 {
 	local rc=$1
@@ -262,6 +264,8 @@ cleanup()
 
 vrf_strict_mode_tests_init()
 {
+	log_section "VRF strict_mode test on init network namespace"
+
 	vrf_strict_mode_check_support init
 
 	strict_mode_check_default init
@@ -292,6 +296,8 @@ vrf_strict_mode_tests_init()
 
 vrf_strict_mode_tests_testns()
 {
+	log_section "VRF strict_mode test on testns network namespace"
+
 	vrf_strict_mode_check_support testns
 
 	strict_mode_check_default testns
@@ -318,6 +324,8 @@ vrf_strict_mode_tests_testns()
 
 vrf_strict_mode_tests_mix()
 {
+	log_section "VRF strict_mode test mixing init and testns network namespaces"
+
 	read_strict_mode_compare_and_check init 1
 
 	read_strict_mode_compare_and_check testns 0
@@ -341,18 +349,30 @@ vrf_strict_mode_tests_mix()
 	read_strict_mode_compare_and_check testns 0
 }
 
-vrf_strict_mode_tests()
-{
-	log_section "VRF strict_mode test on init network namespace"
-	vrf_strict_mode_tests_init
+################################################################################
+# usage
 
-	log_section "VRF strict_mode test on testns network namespace"
-	vrf_strict_mode_tests_testns
+usage()
+{
+	cat <<EOF
+usage: ${0##*/} OPTS
 
-	log_section "VRF strict_mode test mixing init and testns network namespaces"
-	vrf_strict_mode_tests_mix
+	-t <test>	Test(s) to run (default: all)
+			(options: $TESTS)
+EOF
 }
 
+################################################################################
+# main
+
+while getopts ":t:h" opt; do
+	case $opt in
+		t) TESTS=$OPTARG;;
+		h) usage; exit 0;;
+		*) usage; exit 1;;
+	esac
+done
+
 vrf_strict_mode_check_support()
 {
 	local nsname=$1
@@ -391,7 +411,17 @@ fi
 cleanup &> /dev/null
 
 setup
-vrf_strict_mode_tests
+for t in $TESTS
+do
+	case $t in
+	vrf_strict_mode_tests_init|init) vrf_strict_mode_tests_init;;
+	vrf_strict_mode_tests_testns|testns) vrf_strict_mode_tests_testns;;
+	vrf_strict_mode_tests_mix|mix) vrf_strict_mode_tests_mix;;
+
+	help) echo "Test names: $TESTS"; exit 0;;
+
+	esac
+done
 cleanup
 
 print_log_test_results
-- 
2.25.1

Re: [PATCH net-next v4] selftests: net: vrf_strict_mode_test: add support to select a test to run

[David Ahern]

On 4/29/22 10:46 AM, Jaehee Park wrote:
> Add a boilerplate test loop to run all tests in
> vrf_strict_mode_test.sh. Add a -t flag that allows a selected test to
> run. Remove the vrf_strict_mode_tests function which is now unused.
> 
> Signed-off-by: Jaehee Park <jhpark1013@gmail.com>
> ---
> v2 
> - Add a -t flag that allows a selected test to
> run.
> 
> v3 
> - Add commented delineators to section the code for improved
> readability.
> - Move the log_section() call into the functions handling the tests.
> - Remove unnecessary spaces.
> 
> v4 
> - Remove unused function
> - Edit the patch log to reflect this change.
> 
> 
>  .../selftests/net/vrf_strict_mode_test.sh     | 48 +++++++++++++++----
>  1 file changed, 39 insertions(+), 9 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@kernel.org>

Re: [PATCH net-next v4] selftests: net: vrf_strict_mode_test: add support to select a test to run

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Fri, 29 Apr 2022 12:46:58 -0400 you wrote:
> Add a boilerplate test loop to run all tests in
> vrf_strict_mode_test.sh. Add a -t flag that allows a selected test to
> run. Remove the vrf_strict_mode_tests function which is now unused.
> 
> Signed-off-by: Jaehee Park <jhpark1013@gmail.com>
> ---
> v2
> - Add a -t flag that allows a selected test to
> run.
> 
> [...]

Here is the summary with links:
  - [net-next,v4] selftests: net: vrf_strict_mode_test: add support to select a test to run
    https://git.kernel.org/netdev/net-next/c/a313f858ed36

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html