* [PATCH v2 net] net: phy: micrel: Fix incorret variable type in micrel
@ 2022-05-09 14:45 Wan Jiabing
2022-05-09 15:11 ` Andrew Lunn
2022-05-10 22:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Wan Jiabing @ 2022-05-09 14:45 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Horatiu Vultur, netdev,
linux-kernel
Cc: Wan Jiabing
In lanphy_read_page_reg, calling __phy_read() might return a negative
error code. Use 'int' to check the error code.
Fixes: 7c2dcfa295b1 ("net: phy: micrel: Add support for LAN8804 PHY")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
Changelog:
v2:
- Add a 'Fixes' tag.
---
drivers/net/phy/micrel.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index a06661c07ca8..c34a93403d1e 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -1959,7 +1959,7 @@ static int ksz886x_cable_test_get_status(struct phy_device *phydev,
static int lanphy_read_page_reg(struct phy_device *phydev, int page, u32 addr)
{
- u32 data;
+ int data;
phy_lock_mdio_bus(phydev);
__phy_write(phydev, LAN_EXT_PAGE_ACCESS_CONTROL, page);
@@ -2660,8 +2660,7 @@ static int lan8804_config_init(struct phy_device *phydev)
static irqreturn_t lan8814_handle_interrupt(struct phy_device *phydev)
{
- u16 tsu_irq_status;
- int irq_status;
+ int irq_status, tsu_irq_status;
irq_status = phy_read(phydev, LAN8814_INTS);
if (irq_status > 0 && (irq_status & LAN8814_INT_LINK))
--
2.36.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2 net] net: phy: micrel: Fix incorret variable type in micrel
2022-05-09 14:45 [PATCH v2 net] net: phy: micrel: Fix incorret variable type in micrel Wan Jiabing
@ 2022-05-09 15:11 ` Andrew Lunn
2022-05-10 22:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2022-05-09 15:11 UTC (permalink / raw)
To: Wan Jiabing
Cc: Heiner Kallweit, Russell King, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Horatiu Vultur, netdev, linux-kernel
On Mon, May 09, 2022 at 10:45:19PM +0800, Wan Jiabing wrote:
> In lanphy_read_page_reg, calling __phy_read() might return a negative
> error code. Use 'int' to check the error code.
>
> Fixes: 7c2dcfa295b1 ("net: phy: micrel: Add support for LAN8804 PHY")
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2 net] net: phy: micrel: Fix incorret variable type in micrel
2022-05-09 14:45 [PATCH v2 net] net: phy: micrel: Fix incorret variable type in micrel Wan Jiabing
2022-05-09 15:11 ` Andrew Lunn
@ 2022-05-10 22:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-05-10 22:30 UTC (permalink / raw)
To: Wan Jiabing
Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni,
horatiu.vultur, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 9 May 2022 22:45:19 +0800 you wrote:
> In lanphy_read_page_reg, calling __phy_read() might return a negative
> error code. Use 'int' to check the error code.
>
> Fixes: 7c2dcfa295b1 ("net: phy: micrel: Add support for LAN8804 PHY")
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> Changelog:
> v2:
> - Add a 'Fixes' tag.
>
> [...]
Here is the summary with links:
- [v2,net] net: phy: micrel: Fix incorret variable type in micrel
https://git.kernel.org/netdev/net/c/12a4d677b1c3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-10 22:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-09 14:45 [PATCH v2 net] net: phy: micrel: Fix incorret variable type in micrel Wan Jiabing
2022-05-09 15:11 ` Andrew Lunn
2022-05-10 22:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).