From: patchwork-bot+netdevbpf@kernel.org
To: Tariq Toukan <tariqt@nvidia.com>
Cc: borisp@nvidia.com, john.fastabend@gmail.com, kuba@kernel.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, saeedm@nvidia.com, gal@nvidia.com,
maximmi@nvidia.com
Subject: Re: [PATCH net] net/tls: Fix race in TLS device down flow
Date: Mon, 18 Jul 2022 10:50:13 +0000 [thread overview]
Message-ID: <165814141330.26482.840632241080820266.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220715084216.4778-1-tariqt@nvidia.com>
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 15 Jul 2022 11:42:16 +0300 you wrote:
> Socket destruction flow and tls_device_down function sync against each
> other using tls_device_lock and the context refcount, to guarantee the
> device resources are freed via tls_dev_del() by the end of
> tls_device_down.
>
> In the following unfortunate flow, this won't happen:
> - refcount is decreased to zero in tls_device_sk_destruct.
> - tls_device_down starts, skips the context as refcount is zero, going
> all the way until it flushes the gc work, and returns without freeing
> the device resources.
> - only then, tls_device_queue_ctx_destruction is called, queues the gc
> work and frees the context's device resources.
>
> [...]
Here is the summary with links:
- [net] net/tls: Fix race in TLS device down flow
https://git.kernel.org/netdev/net/c/f08d8c1bb97c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-07-18 10:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 8:42 [PATCH net] net/tls: Fix race in TLS device down flow Tariq Toukan
2022-07-15 23:38 ` Jakub Kicinski
2022-07-18 10:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165814141330.26482.840632241080820266.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=maximmi@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).