From: patchwork-bot+netdevbpf@kernel.org
To: Taehee Yoo <ap420073@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH net v2 0/8] amt: fix validation and synchronization bugs
Date: Tue, 19 Jul 2022 10:50:15 +0000 [thread overview]
Message-ID: <165822781506.1764.166272738384218919.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220717160910.19156-1-ap420073@gmail.com>
Hello:
This series was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Sun, 17 Jul 2022 16:09:02 +0000 you wrote:
> There are some synchronization issues in the amt module.
> Especially, an amt gateway doesn't well synchronize its own variables
> and status(amt->status).
> It tries to use a workqueue for handles in a single thread.
> A global lock is also good, but it would occur complex locking complex.
>
> In this patchset, only the gateway uses workqueue.
> The reason why only gateway interface uses workqueue is that gateway
> should manage its own states and variables a little bit statefully.
> But relay doesn't need to manage tunnels statefully, stateless is okay.
> So, relay side message handlers are okay to be called concurrently.
> But it doesn't mean that no lock is needed.
>
> [...]
Here is the summary with links:
- [net,v2,1/8] amt: use workqueue for gateway side message handling
https://git.kernel.org/netdev/net/c/30e22a6ebca0
- [net,v2,2/8] amt: remove unnecessary locks
https://git.kernel.org/netdev/net/c/9c343ea6185f
- [net,v2,3/8] amt: use READ_ONCE() in amt module
https://git.kernel.org/netdev/net/c/928f353cb867
- [net,v2,4/8] amt: add missing regeneration nonce logic in request logic
https://git.kernel.org/netdev/net/c/627f16931bf3
- [net,v2,5/8] amt: drop unexpected advertisement message
https://git.kernel.org/netdev/net/c/40185f359fba
- [net,v2,6/8] amt: drop unexpected query message
https://git.kernel.org/netdev/net/c/239d886601e3
- [net,v2,7/8] amt: drop unexpected multicast data
https://git.kernel.org/netdev/net/c/e882827d5b89
- [net,v2,8/8] amt: do not use amt->nr_tunnels outside of lock
https://git.kernel.org/netdev/net/c/989918482bbc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-07-19 10:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-17 16:09 [PATCH net v2 0/8] amt: fix validation and synchronization bugs Taehee Yoo
2022-07-17 16:09 ` [PATCH net v2 1/8] amt: use workqueue for gateway side message handling Taehee Yoo
2022-07-17 16:09 ` [PATCH net v2 2/8] amt: remove unnecessary locks Taehee Yoo
2022-07-17 16:09 ` [PATCH net v2 3/8] amt: use READ_ONCE() in amt module Taehee Yoo
2022-07-17 16:09 ` [PATCH net v2 4/8] amt: add missing regeneration nonce logic in request logic Taehee Yoo
2022-07-17 16:09 ` [PATCH net v2 5/8] amt: drop unexpected advertisement message Taehee Yoo
2022-07-17 16:09 ` [PATCH net v2 6/8] amt: drop unexpected query message Taehee Yoo
2022-07-17 16:09 ` [PATCH net v2 7/8] amt: drop unexpected multicast data Taehee Yoo
2022-07-17 16:09 ` [PATCH net v2 8/8] amt: do not use amt->nr_tunnels outside of lock Taehee Yoo
2022-07-19 10:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165822781506.1764.166272738384218919.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).