From: patchwork-bot+netdevbpf@kernel.org
To: Taehee Yoo <ap420073@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
netdev@vger.kernel.org, liuhangbin@gmail.com
Subject: Re: [PATCH net v2] net: mld: fix reference count leak in mld_{query | report}_work()
Date: Mon, 25 Jul 2022 11:40:13 +0000 [thread overview]
Message-ID: <165874921340.25231.17481959950698631240.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220722170635.14847-1-ap420073@gmail.com>
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 22 Jul 2022 17:06:35 +0000 you wrote:
> mld_{query | report}_work() processes queued events.
> If there are too many events in the queue, it re-queue a work.
> And then, it returns without in6_dev_put().
> But if queuing is failed, it should call in6_dev_put(), but it doesn't.
> So, a reference count leak would occur.
>
> THREAD0 THREAD1
> mld_report_work()
> spin_lock_bh()
> if (!mod_delayed_work())
> in6_dev_hold();
> spin_unlock_bh()
> spin_lock_bh()
> schedule_delayed_work()
> spin_unlock_bh()
>
> [...]
Here is the summary with links:
- [net,v2] net: mld: fix reference count leak in mld_{query | report}_work()
https://git.kernel.org/netdev/net/c/3e7d18b9dca3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-07-25 11:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 17:06 [PATCH net v2] net: mld: fix reference count leak in mld_{query | report}_work() Taehee Yoo
2022-07-22 17:08 ` Eric Dumazet
2022-07-25 11:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165874921340.25231.17481959950698631240.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).