* [PATCH net] ptp: ocp: Select CRC16 in the Kconfig.
@ 2022-07-26 22:06 Jonathan Lemon
2022-07-28 0:04 ` Vadim Fedorenko
2022-07-28 1:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jonathan Lemon @ 2022-07-26 22:06 UTC (permalink / raw)
To: netdev
Cc: davem, kuba, pabeni, edumazet, kernel-team, kernel test robot,
Richard Cochran, Vadim Fedorenko
The crc16() function is used to check the firmware validity, but
the library was not explicitly selected.
Fixes: 3c3673bde50c ("ptp: ocp: Add firmware header checks")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
---
CC: Richard Cochran <richardcochran@gmail.com>
CC: Vadim Fedorenko <vadfed@fb.com>
---
drivers/ptp/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index 458218f88c5e..fe4971b65c64 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -176,6 +176,7 @@ config PTP_1588_CLOCK_OCP
depends on !S390
depends on COMMON_CLK
select NET_DEVLINK
+ select CRC16
help
This driver adds support for an OpenCompute time card.
--
2.34.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] ptp: ocp: Select CRC16 in the Kconfig.
2022-07-26 22:06 [PATCH net] ptp: ocp: Select CRC16 in the Kconfig Jonathan Lemon
@ 2022-07-28 0:04 ` Vadim Fedorenko
2022-07-28 1:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Vadim Fedorenko @ 2022-07-28 0:04 UTC (permalink / raw)
To: Jonathan Lemon, netdev
Cc: davem, kuba, pabeni, edumazet, kernel-team, kernel test robot,
Richard Cochran, Vadim Fedorenko
On 26.07.2022 23:06, Jonathan Lemon wrote:
> The crc16() function is used to check the firmware validity, but
> the library was not explicitly selected.
>
> Fixes: 3c3673bde50c ("ptp: ocp: Add firmware header checks")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
> ---
> CC: Richard Cochran <richardcochran@gmail.com>
> CC: Vadim Fedorenko <vadfed@fb.com>
> ---
> drivers/ptp/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Vadim Fedorenko <vadfed@fb.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] ptp: ocp: Select CRC16 in the Kconfig.
2022-07-26 22:06 [PATCH net] ptp: ocp: Select CRC16 in the Kconfig Jonathan Lemon
2022-07-28 0:04 ` Vadim Fedorenko
@ 2022-07-28 1:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-07-28 1:30 UTC (permalink / raw)
To: Jonathan Lemon
Cc: netdev, davem, kuba, pabeni, edumazet, kernel-team, lkp,
richardcochran, vadfed
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 26 Jul 2022 15:06:04 -0700 you wrote:
> The crc16() function is used to check the firmware validity, but
> the library was not explicitly selected.
>
> Fixes: 3c3673bde50c ("ptp: ocp: Add firmware header checks")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
>
> [...]
Here is the summary with links:
- [net] ptp: ocp: Select CRC16 in the Kconfig.
https://git.kernel.org/netdev/net/c/0c1045562672
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-28 1:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-26 22:06 [PATCH net] ptp: ocp: Select CRC16 in the Kconfig Jonathan Lemon
2022-07-28 0:04 ` Vadim Fedorenko
2022-07-28 1:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).