* [patch net-next] net: devlink: remove redundant net_eq() check from sb_pool_get_dumpit()
@ 2022-07-27 5:59 Jiri Pirko
2022-07-28 3:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Pirko @ 2022-07-27 5:59 UTC (permalink / raw)
To: netdev; +Cc: davem, kuba, pabeni, edumazet
From: Jiri Pirko <jiri@nvidia.com>
The net_eq() check is already performed inside
devlinks_xa_for_each_registered_get() helper, so remove the redundant
appearance.
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
---
net/core/devlink.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index 698b2d6e0ec7..ca4c9939d569 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -2642,8 +2642,7 @@ static int devlink_nl_cmd_sb_pool_get_dumpit(struct sk_buff *msg,
mutex_lock(&devlink_mutex);
devlinks_xa_for_each_registered_get(sock_net(msg->sk), index, devlink) {
- if (!net_eq(devlink_net(devlink), sock_net(msg->sk)) ||
- !devlink->ops->sb_pool_get)
+ if (!devlink->ops->sb_pool_get)
goto retry;
devl_lock(devlink);
--
2.35.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch net-next] net: devlink: remove redundant net_eq() check from sb_pool_get_dumpit()
2022-07-27 5:59 [patch net-next] net: devlink: remove redundant net_eq() check from sb_pool_get_dumpit() Jiri Pirko
@ 2022-07-28 3:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-07-28 3:50 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev, davem, kuba, pabeni, edumazet
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 27 Jul 2022 07:59:12 +0200 you wrote:
> From: Jiri Pirko <jiri@nvidia.com>
>
> The net_eq() check is already performed inside
> devlinks_xa_for_each_registered_get() helper, so remove the redundant
> appearance.
>
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
>
> [...]
Here is the summary with links:
- [net-next] net: devlink: remove redundant net_eq() check from sb_pool_get_dumpit()
https://git.kernel.org/netdev/net-next/c/2bb88b2c4f73
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-28 3:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-27 5:59 [patch net-next] net: devlink: remove redundant net_eq() check from sb_pool_get_dumpit() Jiri Pirko
2022-07-28 3:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).