* [PATCH net-next] net/tls: Remove redundant workqueue flush before destroy
@ 2022-08-01 11:24 Tariq Toukan
2022-08-01 19:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Tariq Toukan @ 2022-08-01 11:24 UTC (permalink / raw)
To: Boris Pismenny, John Fastabend, Jakub Kicinski
Cc: David S. Miller, Eric Dumazet, Paolo Abeni, netdev,
Saeed Mahameed, Gal Pressman, Maxim Mikityanskiy, Tariq Toukan
destroy_workqueue() safely destroys the workqueue after draining it.
No need for the explicit call to flush_workqueue(). Remove it.
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
net/tls/tls_device.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
index 18c7e5c6d228..e3e6cf75aa03 100644
--- a/net/tls/tls_device.c
+++ b/net/tls/tls_device.c
@@ -1449,7 +1449,6 @@ int __init tls_device_init(void)
void __exit tls_device_cleanup(void)
{
unregister_netdevice_notifier(&tls_dev_notifier);
- flush_workqueue(destruct_wq);
destroy_workqueue(destruct_wq);
clean_acked_data_flush();
}
--
2.21.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net/tls: Remove redundant workqueue flush before destroy
2022-08-01 11:24 [PATCH net-next] net/tls: Remove redundant workqueue flush before destroy Tariq Toukan
@ 2022-08-01 19:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-08-01 19:50 UTC (permalink / raw)
To: Tariq Toukan
Cc: borisp, john.fastabend, kuba, davem, edumazet, pabeni, netdev,
saeedm, gal, maximmi
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 1 Aug 2022 14:24:44 +0300 you wrote:
> destroy_workqueue() safely destroys the workqueue after draining it.
> No need for the explicit call to flush_workqueue(). Remove it.
>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> ---
> net/tls/tls_device.c | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- [net-next] net/tls: Remove redundant workqueue flush before destroy
https://git.kernel.org/netdev/net-next/c/d81c7cdd7a6d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-01 19:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-01 11:24 [PATCH net-next] net/tls: Remove redundant workqueue flush before destroy Tariq Toukan
2022-08-01 19:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).