From: patchwork-bot+netdevbpf@kernel.org
To: c b <cbulinaru@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, willemb@google.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v5 net] net: tap: NULL pointer derefence in dev_parse_header_protocol when skb->dev is null
Date: Fri, 05 Aug 2022 08:00:14 +0000 [thread overview]
Message-ID: <165968641477.31624.9662939829824626375.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220803062759.3967-1-cbulinaru@gmail.com>
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 3 Aug 2022 02:27:59 -0400 you wrote:
> Fixes a NULL pointer derefence bug triggered from tap driver.
> When tap_get_user calls virtio_net_hdr_to_skb the skb->dev is null
> (in tap.c skb->dev is set after the call to virtio_net_hdr_to_skb)
> virtio_net_hdr_to_skb calls dev_parse_header_protocol which
> needs skb->dev field to be valid.
>
> The line that trigers the bug is in dev_parse_header_protocol
> (dev is at offset 0x10 from skb and is stored in RAX register)
> if (!dev->header_ops || !dev->header_ops->parse_protocol)
> 22e1: mov 0x10(%rbx),%rax
> 22e5: mov 0x230(%rax),%rax
>
> [...]
Here is the summary with links:
- [v5,net] net: tap: NULL pointer derefence in dev_parse_header_protocol when skb->dev is null
https://git.kernel.org/netdev/net/c/4f61f133f354
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-08-05 8:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 6:27 [PATCH v5 net] net: tap: NULL pointer derefence in dev_parse_header_protocol when skb->dev is null Cezar Bulinaru
2022-08-03 11:12 ` Willem de Bruijn
2022-08-05 8:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165968641477.31624.9662939829824626375.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=cbulinaru@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).