From: Rob Herring <robh@kernel.org>
To: wei.fang@nxp.com
Cc: andrew@lunn.ch, pabeni@redhat.com, robh+dt@kernel.org,
f.fainelli@gmail.com, hkallweit1@gmail.com,
netdev@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
linux@armlinux.org.uk, edumazet@google.com, kuba@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH net 1/2] dt: ar803x: Document disable-hibernation property
Date: Fri, 12 Aug 2022 09:13:53 -0600 [thread overview]
Message-ID: <1660317233.459028.168985.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220812145009.1229094-2-wei.fang@nxp.com>
On Sat, 13 Aug 2022 00:50:08 +1000, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
>
> The hibernation mode of Atheros AR803x PHYs is default enabled.
> When the cable is unplugged, the PHY will enter hibernation
> mode and the PHY clock does down. For some MACs, it needs the
> clock to support it's logic. For instance, stmmac needs the PHY
> inputs clock is present for software reset completion. Therefore,
> It is reasonable to add a DT property to disable hibernation mode.
>
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
> Documentation/devicetree/bindings/net/qca,ar803x.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/net/qca,ar803x.yaml:46:5: [error] syntax error: could not find expected ':' (syntax)
dtschema/dtc warnings/errors:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/net/qca,ar803x.example.dts'
Documentation/devicetree/bindings/net/qca,ar803x.yaml:46:5: could not find expected ':'
make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/net/qca,ar803x.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/net/qca,ar803x.yaml:46:5: could not find expected ':'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/qca,ar803x.yaml: ignoring, error parsing file
make: *** [Makefile:1404: dt_binding_check] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-08-12 15:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 14:50 [PATCH net 0/2] Add DT property to disable hibernation mode wei.fang
2022-08-12 14:50 ` [PATCH net 1/2] dt: ar803x: Document disable-hibernation property wei.fang
2022-08-12 7:27 ` Krzysztof Kozlowski
2022-08-12 9:02 ` Wei Fang
2022-08-12 11:25 ` Krzysztof Kozlowski
2022-08-12 11:36 ` Russell King (Oracle)
2022-08-12 12:04 ` Krzysztof Kozlowski
2022-08-12 12:30 ` Russell King (Oracle)
2022-08-12 12:36 ` Krzysztof Kozlowski
2022-08-12 14:34 ` Russell King (Oracle)
2022-08-15 8:51 ` Wei Fang
2022-08-15 9:19 ` Russell King (Oracle)
2022-08-12 14:15 ` Andrew Lunn
2022-08-15 6:49 ` Wei Fang
2022-08-18 1:20 ` Andrew Lunn
2022-08-18 1:29 ` Wei Fang
2022-08-18 1:44 ` Andrew Lunn
2022-08-18 1:50 ` Wei Fang
2022-08-18 2:01 ` Wei Fang
2022-08-12 15:13 ` Rob Herring [this message]
2022-08-12 15:36 ` Andrew Lunn
2022-08-12 14:50 ` [PATCH net 2/2] net: phy: at803x: Add disable hibernation mode support wei.fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1660317233.459028.168985.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).