From: patchwork-bot+netdevbpf@kernel.org
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, vivien.didelot@gmail.com,
f.fainelli@gmail.com, claudiu.manoil@nxp.com,
alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, colin.foster@in-advantage.com,
fido_max@inbox.ru
Subject: Re: [PATCH net 0/8] Fixes for Ocelot driver statistics
Date: Thu, 18 Aug 2022 05:20:17 +0000 [thread overview]
Message-ID: <166080001748.8479.564394540738537882.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220816135352.1431497-1-vladimir.oltean@nxp.com>
Hello:
This series was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 16 Aug 2022 16:53:44 +0300 you wrote:
> This series contains bug fixes for the ocelot drivers (both switchdev
> and DSA). Some concern the counters exposed to ethtool -S, and others to
> the counters exposed to ifconfig. I'm aware that the changes are fairly
> large, but I wanted to prioritize on a proper approach to addressing the
> issues rather than a quick hack.
>
> Some of the noticed problems:
> - bad register offsets for some counters
> - unhandled concurrency leading to corrupted counters
> - unhandled 32-bit wraparound of ifconfig counters
>
> [...]
Here is the summary with links:
- [net,1/8] net: dsa: felix: fix ethtool 256-511 and 512-1023 TX packet counters
https://git.kernel.org/netdev/net/c/40d21c4565bc
- [net,2/8] net: mscc: ocelot: fix incorrect ndo_get_stats64 packet counters
https://git.kernel.org/netdev/net/c/5152de7b79ab
- [net,3/8] net: mscc: ocelot: fix address of SYS_COUNT_TX_AGING counter
https://git.kernel.org/netdev/net/c/173ca86618d7
- [net,4/8] net: mscc: ocelot: turn stats_lock into a spinlock
https://git.kernel.org/netdev/net/c/22d842e3efe5
- [net,5/8] net: mscc: ocelot: fix race between ndo_get_stats64 and ocelot_check_stats_work
https://git.kernel.org/netdev/net/c/18d8e67df184
- [net,6/8] net: mscc: ocelot: make struct ocelot_stat_layout array indexable
https://git.kernel.org/netdev/net/c/9190460084dd
- [net,7/8] net: mscc: ocelot: keep ocelot_stat_layout by reg address, not offset
https://git.kernel.org/netdev/net/c/d4c367650704
- [net,8/8] net: mscc: ocelot: report ndo_get_stats64 from the wraparound-resistant ocelot->stats
https://git.kernel.org/netdev/net/c/e780e3193e88
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-08-18 5:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 13:53 [PATCH net 0/8] Fixes for Ocelot driver statistics Vladimir Oltean
2022-08-16 13:53 ` [PATCH net 1/8] net: dsa: felix: fix ethtool 256-511 and 512-1023 TX packet counters Vladimir Oltean
2022-08-16 13:53 ` [PATCH net 2/8] net: mscc: ocelot: fix incorrect ndo_get_stats64 " Vladimir Oltean
2022-08-17 6:26 ` Colin Foster
2022-08-16 13:53 ` [PATCH net 3/8] net: mscc: ocelot: fix address of SYS_COUNT_TX_AGING counter Vladimir Oltean
2022-08-16 13:53 ` [PATCH net 4/8] net: mscc: ocelot: turn stats_lock into a spinlock Vladimir Oltean
2022-08-16 13:53 ` [PATCH net 5/8] net: mscc: ocelot: fix race between ndo_get_stats64 and ocelot_check_stats_work Vladimir Oltean
2022-08-16 13:53 ` [PATCH net 6/8] net: mscc: ocelot: make struct ocelot_stat_layout array indexable Vladimir Oltean
2022-08-17 6:46 ` Colin Foster
2022-08-17 11:06 ` Vladimir Oltean
2022-08-17 13:05 ` Vladimir Oltean
2022-08-17 15:14 ` Colin Foster
2022-08-17 17:42 ` Vladimir Oltean
2022-08-17 20:47 ` Colin Foster
2022-08-17 22:03 ` Vladimir Oltean
2022-08-17 22:07 ` Colin Foster
2022-08-18 6:01 ` Colin Foster
2022-08-16 13:53 ` [PATCH net 7/8] net: mscc: ocelot: keep ocelot_stat_layout by reg address, not offset Vladimir Oltean
2022-08-16 13:53 ` [PATCH net 8/8] net: mscc: ocelot: report ndo_get_stats64 from the wraparound-resistant ocelot->stats Vladimir Oltean
2022-08-18 5:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166080001748.8479.564394540738537882.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=fido_max@inbox.ru \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).