* [PATCH net 0/4] bnxt_en: Bug fixes.
@ 2018-12-09 12:00 Michael Chan
2018-12-09 19:47 ` David Miller
0 siblings, 1 reply; 22+ messages in thread
From: Michael Chan @ 2018-12-09 12:00 UTC (permalink / raw)
To: davem; +Cc: netdev
The first patch fixes a regression on CoS queue setup, introduced
recently by the 57500 new chip support patches. The rest are
fixes related to ring and resource accounting on the new 57500 chips.
Michael Chan (4):
bnxt_en: Fix CNP CoS queue regression.
bnxt_en: Keep track of reserved IRQs.
bnxt_en: Fix NQ/CP rings accounting on the new 57500 chips.
bnxt_en: Fix _bnxt_get_max_rings() for 57500 chips.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 60 +++++++++++++++++++++------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 2 +-
3 files changed, 50 insertions(+), 13 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH net 0/4] bnxt_en: Bug fixes.
2018-12-09 12:00 Michael Chan
@ 2018-12-09 19:47 ` David Miller
0 siblings, 0 replies; 22+ messages in thread
From: David Miller @ 2018-12-09 19:47 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Sun, 9 Dec 2018 07:00:58 -0500
> The first patch fixes a regression on CoS queue setup, introduced
> recently by the 57500 new chip support patches. The rest are
> fixes related to ring and resource accounting on the new 57500 chips.
Series applied.
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH net 0/4] bnxt_en: Bug fixes.
@ 2019-05-22 23:12 Michael Chan
2019-05-23 1:03 ` David Miller
0 siblings, 1 reply; 22+ messages in thread
From: Michael Chan @ 2019-05-22 23:12 UTC (permalink / raw)
To: davem; +Cc: netdev
There are 4 driver fixes in this series:
1. Fix RX buffer leak during OOM condition.
2. Call pci_disable_msix() under correct conditions to prevent hitting BUG.
3. Reduce unneeded mmeory allocation in kdump kernel to prevent OOM.
4. Don't read device serial number on VFs because it is not supported.
Please queue #1, #2, #3 for -stable as well. Thanks.
Michael Chan (3):
bnxt_en: Fix aggregation buffer leak under OOM condition.
bnxt_en: Fix possible BUG() condition when calling pci_disable_msix().
bnxt_en: Reduce memory usage when running in kdump kernel.
Vasundhara Volam (1):
bnxt_en: Device serial number is supported only for PFs.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 30 +++++++++++++----------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 6 +++--
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 2 +-
4 files changed, 23 insertions(+), 17 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH net 0/4] bnxt_en: Bug fixes.
2019-05-22 23:12 Michael Chan
@ 2019-05-23 1:03 ` David Miller
0 siblings, 0 replies; 22+ messages in thread
From: David Miller @ 2019-05-23 1:03 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Wed, 22 May 2019 19:12:53 -0400
> There are 4 driver fixes in this series:
>
> 1. Fix RX buffer leak during OOM condition.
> 2. Call pci_disable_msix() under correct conditions to prevent hitting BUG.
> 3. Reduce unneeded mmeory allocation in kdump kernel to prevent OOM.
> 4. Don't read device serial number on VFs because it is not supported.
Series applied.
> Please queue #1, #2, #3 for -stable as well. Thanks.
Queued up, thank you.
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH net 0/4] bnxt_en: Bug fixes.
@ 2020-02-02 7:41 Michael Chan
2020-02-03 23:22 ` Jakub Kicinski
0 siblings, 1 reply; 22+ messages in thread
From: Michael Chan @ 2020-02-02 7:41 UTC (permalink / raw)
To: davem; +Cc: netdev
3 patches that fix some issues in the firmware reset logic, starting
with a small patch to refactor the code that re-enables SRIOV. The
last patch fixes a TC queue mapping issue.
Michael Chan (3):
bnxt_en: Refactor logic to re-enable SRIOV after firmware reset
detected.
bnxt_en: Fix RDMA driver failure with SRIOV after firmware reset.
bnxt_en: Fix TC queue mapping.
Vasundhara Volam (1):
bnxt_en: Fix logic that disables Bus Master during firmware reset.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 37 ++++++++++++++++++++-----------
1 file changed, 24 insertions(+), 13 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH net 0/4] bnxt_en: Bug fixes.
2020-02-02 7:41 Michael Chan
@ 2020-02-03 23:22 ` Jakub Kicinski
0 siblings, 0 replies; 22+ messages in thread
From: Jakub Kicinski @ 2020-02-03 23:22 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev
On Sun, 2 Feb 2020 02:41:34 -0500, Michael Chan wrote:
> 3 patches that fix some issues in the firmware reset logic, starting
> with a small patch to refactor the code that re-enables SRIOV. The
> last patch fixes a TC queue mapping issue.
>
> Michael Chan (3):
> bnxt_en: Refactor logic to re-enable SRIOV after firmware reset
> detected.
> bnxt_en: Fix RDMA driver failure with SRIOV after firmware reset.
> bnxt_en: Fix TC queue mapping.
>
> Vasundhara Volam (1):
> bnxt_en: Fix logic that disables Bus Master during firmware reset.
Applied and added to stable queued, thank you!
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH net 0/4] bnxt_en: Bug fixes.
@ 2020-06-14 23:57 Michael Chan
2020-06-15 20:29 ` David Miller
0 siblings, 1 reply; 22+ messages in thread
From: Michael Chan @ 2020-06-14 23:57 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba
Four fixes related to the bnxt_en driver's resume path, AER reset, and
the timer function.
Michael Chan (3):
bnxt_en: Simplify bnxt_resume().
bnxt_en: Re-enable SRIOV during resume.
bnxt_en: Fix AER reset logic on 57500 chips.
Vasundhara Volam (1):
bnxt_en: Return from timer if interface is not in open state.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 35 +++++++++++++++----------------
1 file changed, 17 insertions(+), 18 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH net 0/4] bnxt_en: Bug fixes.
2020-06-14 23:57 Michael Chan
@ 2020-06-15 20:29 ` David Miller
0 siblings, 0 replies; 22+ messages in thread
From: David Miller @ 2020-06-15 20:29 UTC (permalink / raw)
To: michael.chan; +Cc: netdev, kuba
From: Michael Chan <michael.chan@broadcom.com>
Date: Sun, 14 Jun 2020 19:57:06 -0400
> Four fixes related to the bnxt_en driver's resume path, AER reset, and
> the timer function.
Series applied, thanks Michael.
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH net 0/4] bnxt_en: Bug fixes.
@ 2020-06-23 23:01 Michael Chan
2020-06-23 23:45 ` Jakub Kicinski
2020-06-24 3:15 ` David Miller
0 siblings, 2 replies; 22+ messages in thread
From: Michael Chan @ 2020-06-23 23:01 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba
The first patch stores the firmware version code which is needed by the
next 2 patches to determine some worarounds based on the firmware version.
The workarounds are to disable legacy TX push mode and to clear the
hardware statistics during ifdown. The last patch checks that it is
a PF before reading the VPD.
Please also queue these for -stable. Thanks.
Michael Chan (3):
bnxt_en: Store the running firmware version code.
bnxt_en: Do not enable legacy TX push on older firmware.
bnxt_en: Fix statistics counters issue during ifdown with older
firmware.
Vasundhara Volam (1):
bnxt_en: Read VPD info only for PFs
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 36 +++++++++++++++++++++++++------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 5 +++++
2 files changed, 34 insertions(+), 7 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH net 0/4] bnxt_en: Bug fixes.
2020-06-23 23:01 Michael Chan
@ 2020-06-23 23:45 ` Jakub Kicinski
2020-06-24 3:15 ` David Miller
1 sibling, 0 replies; 22+ messages in thread
From: Jakub Kicinski @ 2020-06-23 23:45 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev
On Tue, 23 Jun 2020 19:01:34 -0400 Michael Chan wrote:
> The first patch stores the firmware version code which is needed by the
> next 2 patches to determine some worarounds based on the firmware version.
> The workarounds are to disable legacy TX push mode and to clear the
> hardware statistics during ifdown. The last patch checks that it is
> a PF before reading the VPD.
>
> Please also queue these for -stable. Thanks.
FWIW looks good to me:
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH net 0/4] bnxt_en: Bug fixes.
2020-06-23 23:01 Michael Chan
2020-06-23 23:45 ` Jakub Kicinski
@ 2020-06-24 3:15 ` David Miller
1 sibling, 0 replies; 22+ messages in thread
From: David Miller @ 2020-06-24 3:15 UTC (permalink / raw)
To: michael.chan; +Cc: netdev, kuba
From: Michael Chan <michael.chan@broadcom.com>
Date: Tue, 23 Jun 2020 19:01:34 -0400
> The first patch stores the firmware version code which is needed by the
> next 2 patches to determine some worarounds based on the firmware version.
> The workarounds are to disable legacy TX push mode and to clear the
> hardware statistics during ifdown. The last patch checks that it is
> a PF before reading the VPD.
Series applied.
> Please also queue these for -stable. Thanks.
Queued up, thanks.
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH net 0/4] bnxt_en: Bug fixes.
@ 2020-11-16 0:27 Michael Chan
2020-11-17 1:44 ` Jakub Kicinski
0 siblings, 1 reply; 22+ messages in thread
From: Michael Chan @ 2020-11-16 0:27 UTC (permalink / raw)
To: kuba; +Cc: netdev, gospo
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
This first patch fixes a module eeprom A2h addressing issue. The next
2 patches fix counter related issues. The last one skips an
unsupported firmware call on the VF to avoid the error log.
Please queue the 1st 3 patches for -stable. Thanks.
Edwin Peer (1):
bnxt_en: read EEPROM A2h address using page 0
Michael Chan (2):
bnxt_en: Free port stats during firmware reset.
bnxt_en: Fix counter overflow logic.
Vasundhara Volam (1):
bnxt_en: Avoid unnecessary NVM_GET_DEV_INFO cmd error log on VFs.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 +++-
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 5 ++++-
2 files changed, 7 insertions(+), 2 deletions(-)
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4166 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH net 0/4] bnxt_en: Bug fixes.
2020-11-16 0:27 Michael Chan
@ 2020-11-17 1:44 ` Jakub Kicinski
0 siblings, 0 replies; 22+ messages in thread
From: Jakub Kicinski @ 2020-11-17 1:44 UTC (permalink / raw)
To: Michael Chan; +Cc: netdev, gospo
On Sun, 15 Nov 2020 19:27:48 -0500 Michael Chan wrote:
> This first patch fixes a module eeprom A2h addressing issue. The next
> 2 patches fix counter related issues. The last one skips an
> unsupported firmware call on the VF to avoid the error log.
>
> Please queue the 1st 3 patches for -stable. Thanks.
Applied, thanks!
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH net 0/4] bnxt_en: Bug fixes
@ 2022-08-22 15:06 Michael Chan
2022-08-22 15:06 ` [PATCH net 1/4] bnxt_en: Use PAGE_SIZE to init buffer when multi buffer XDP is not in use Michael Chan
` (5 more replies)
0 siblings, 6 replies; 22+ messages in thread
From: Michael Chan @ 2022-08-22 15:06 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, edumazet, pabeni, gospo
[-- Attachment #1: Type: text/plain, Size: 833 bytes --]
This series includes 2 fixes for regressions introduced by the XDP
multi-buffer feature, 1 devlink reload bug fix, and 1 SRIOV resource
accounting bug fix.
Pavan Chebbi (1):
bnxt_en: Use PAGE_SIZE to init buffer when multi buffer XDP is not in
use
Vikas Gupta (3):
bnxt_en: set missing reload flag in devlink features
bnxt_en: fix NQ resource accounting during vf creation on 57500 chips
bnxt_en: fix LRO/GRO_HW features in ndo_fix_features callback
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 +----
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 1 +
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 2 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 10 ++++++++--
5 files changed, 12 insertions(+), 7 deletions(-)
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH net 1/4] bnxt_en: Use PAGE_SIZE to init buffer when multi buffer XDP is not in use
2022-08-22 15:06 [PATCH net 0/4] bnxt_en: Bug fixes Michael Chan
@ 2022-08-22 15:06 ` Michael Chan
2022-08-22 15:06 ` [PATCH net 2/4] bnxt_en: set missing reload flag in devlink features Michael Chan
` (4 subsequent siblings)
5 siblings, 0 replies; 22+ messages in thread
From: Michael Chan @ 2022-08-22 15:06 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, edumazet, pabeni, gospo, Pavan Chebbi
[-- Attachment #1: Type: text/plain, Size: 2503 bytes --]
From: Pavan Chebbi <pavan.chebbi@broadcom.com>
Using BNXT_PAGE_MODE_BUF_SIZE + offset as buffer length value is not
sufficient when running single buffer XDP programs doing redirect
operations. The stack will complain on missing skb tail room. Fix it
by using PAGE_SIZE when calling xdp_init_buff() for single buffer
programs.
Fixes: b231c3f3414c ("bnxt: refactor bnxt_rx_xdp to separate xdp_init_buff/xdp_prepare_buff")
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 10 ++++++++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
index 075c6206325c..b1b17f911300 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
@@ -2130,6 +2130,7 @@ struct bnxt {
#define BNXT_DUMP_CRASH 1
struct bpf_prog *xdp_prog;
+ u8 xdp_has_frags;
struct bnxt_ptp_cfg *ptp_cfg;
u8 ptp_all_rx_tstamp;
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
index f53387ed0167..c3065ec0a479 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
@@ -181,6 +181,7 @@ void bnxt_xdp_buff_init(struct bnxt *bp, struct bnxt_rx_ring_info *rxr,
struct xdp_buff *xdp)
{
struct bnxt_sw_rx_bd *rx_buf;
+ u32 buflen = PAGE_SIZE;
struct pci_dev *pdev;
dma_addr_t mapping;
u32 offset;
@@ -192,7 +193,10 @@ void bnxt_xdp_buff_init(struct bnxt *bp, struct bnxt_rx_ring_info *rxr,
mapping = rx_buf->mapping - bp->rx_dma_offset;
dma_sync_single_for_cpu(&pdev->dev, mapping + offset, *len, bp->rx_dir);
- xdp_init_buff(xdp, BNXT_PAGE_MODE_BUF_SIZE + offset, &rxr->xdp_rxq);
+ if (bp->xdp_has_frags)
+ buflen = BNXT_PAGE_MODE_BUF_SIZE + offset;
+
+ xdp_init_buff(xdp, buflen, &rxr->xdp_rxq);
xdp_prepare_buff(xdp, *data_ptr - offset, offset, *len, false);
}
@@ -397,8 +401,10 @@ static int bnxt_xdp_set(struct bnxt *bp, struct bpf_prog *prog)
netdev_warn(dev, "ethtool rx/tx channels must be combined to support XDP.\n");
return -EOPNOTSUPP;
}
- if (prog)
+ if (prog) {
tx_xdp = bp->rx_nr_rings;
+ bp->xdp_has_frags = prog->aux->xdp_has_frags;
+ }
tc = netdev_get_num_tc(dev);
if (!tc)
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH net 2/4] bnxt_en: set missing reload flag in devlink features
2022-08-22 15:06 [PATCH net 0/4] bnxt_en: Bug fixes Michael Chan
2022-08-22 15:06 ` [PATCH net 1/4] bnxt_en: Use PAGE_SIZE to init buffer when multi buffer XDP is not in use Michael Chan
@ 2022-08-22 15:06 ` Michael Chan
2022-08-22 15:06 ` [PATCH net 3/4] bnxt_en: fix NQ resource accounting during vf creation on 57500 chips Michael Chan
` (3 subsequent siblings)
5 siblings, 0 replies; 22+ messages in thread
From: Michael Chan @ 2022-08-22 15:06 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, edumazet, pabeni, gospo, Vikas Gupta
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
From: Vikas Gupta <vikas.gupta@broadcom.com>
Add missing devlink_set_features() API for callbacks reload_down
and reload_up to function.
Fixes: 228ea8c187d8 ("bnxt_en: implement devlink dev reload driver_reinit")
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
index 059f96f7a96f..a36803e79e92 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
@@ -1306,6 +1306,7 @@ int bnxt_dl_register(struct bnxt *bp)
if (rc)
goto err_dl_port_unreg;
+ devlink_set_features(dl, DEVLINK_F_RELOAD);
out:
devlink_register(dl);
return 0;
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH net 3/4] bnxt_en: fix NQ resource accounting during vf creation on 57500 chips
2022-08-22 15:06 [PATCH net 0/4] bnxt_en: Bug fixes Michael Chan
2022-08-22 15:06 ` [PATCH net 1/4] bnxt_en: Use PAGE_SIZE to init buffer when multi buffer XDP is not in use Michael Chan
2022-08-22 15:06 ` [PATCH net 2/4] bnxt_en: set missing reload flag in devlink features Michael Chan
@ 2022-08-22 15:06 ` Michael Chan
2022-08-22 15:06 ` [PATCH net 4/4] bnxt_en: fix LRO/GRO_HW features in ndo_fix_features callback Michael Chan
` (2 subsequent siblings)
5 siblings, 0 replies; 22+ messages in thread
From: Michael Chan @ 2022-08-22 15:06 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, edumazet, pabeni, gospo, Vikas Gupta
[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]
From: Vikas Gupta <vikas.gupta@broadcom.com>
There are 2 issues:
1. We should decrement hw_resc->max_nqs instead of hw_resc->max_irqs
with the number of NQs assigned to the VFs. The IRQs are fixed
on each function and cannot be re-assigned. Only the NQs are being
assigned to the VFs.
2. vf_msix is the total number of NQs to be assigned to the VFs. So
we should decrement vf_msix from hw_resc->max_nqs.
Fixes: b16b68918674 ("bnxt_en: Add SR-IOV support for 57500 chips.")
Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c
index 730febd19330..a4cba7cb2783 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c
@@ -623,7 +623,7 @@ static int bnxt_hwrm_func_vf_resc_cfg(struct bnxt *bp, int num_vfs, bool reset)
hw_resc->max_stat_ctxs -= le16_to_cpu(req->min_stat_ctx) * n;
hw_resc->max_vnics -= le16_to_cpu(req->min_vnics) * n;
if (bp->flags & BNXT_FLAG_CHIP_P5)
- hw_resc->max_irqs -= vf_msix * n;
+ hw_resc->max_nqs -= vf_msix;
rc = pf->active_vfs;
}
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH net 4/4] bnxt_en: fix LRO/GRO_HW features in ndo_fix_features callback
2022-08-22 15:06 [PATCH net 0/4] bnxt_en: Bug fixes Michael Chan
` (2 preceding siblings ...)
2022-08-22 15:06 ` [PATCH net 3/4] bnxt_en: fix NQ resource accounting during vf creation on 57500 chips Michael Chan
@ 2022-08-22 15:06 ` Michael Chan
2022-08-23 3:04 ` [PATCH net 0/4] bnxt_en: Bug fixes Jakub Kicinski
2022-08-23 22:40 ` patchwork-bot+netdevbpf
5 siblings, 0 replies; 22+ messages in thread
From: Michael Chan @ 2022-08-22 15:06 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, edumazet, pabeni, gospo, Vikas Gupta
[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]
From: Vikas Gupta <vikas.gupta@broadcom.com>
LRO/GRO_HW should be disabled if there is an attached XDP program.
BNXT_FLAG_TPA is the current setting of the LRO/GRO_HW. Using
BNXT_FLAG_TPA to disable LRO/GRO_HW will cause these features to be
permanently disabled once they are disabled.
Fixes: 1dc4c557bfed ("bnxt: adding bnxt_xdp_build_skb to build skb from multibuffer xdp_buff")
Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index ba0f1ffac507..f46eefb5a029 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -11178,10 +11178,7 @@ static netdev_features_t bnxt_fix_features(struct net_device *dev,
if ((features & NETIF_F_NTUPLE) && !bnxt_rfs_capable(bp))
features &= ~NETIF_F_NTUPLE;
- if (bp->flags & BNXT_FLAG_NO_AGG_RINGS)
- features &= ~(NETIF_F_LRO | NETIF_F_GRO_HW);
-
- if (!(bp->flags & BNXT_FLAG_TPA))
+ if ((bp->flags & BNXT_FLAG_NO_AGG_RINGS) || bp->xdp_prog)
features &= ~(NETIF_F_LRO | NETIF_F_GRO_HW);
if (!(features & NETIF_F_GRO))
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH net 0/4] bnxt_en: Bug fixes
2022-08-22 15:06 [PATCH net 0/4] bnxt_en: Bug fixes Michael Chan
` (3 preceding siblings ...)
2022-08-22 15:06 ` [PATCH net 4/4] bnxt_en: fix LRO/GRO_HW features in ndo_fix_features callback Michael Chan
@ 2022-08-23 3:04 ` Jakub Kicinski
2022-08-23 22:40 ` patchwork-bot+netdevbpf
5 siblings, 0 replies; 22+ messages in thread
From: Jakub Kicinski @ 2022-08-23 3:04 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, edumazet, pabeni, gospo
On Mon, 22 Aug 2022 11:06:50 -0400 Michael Chan wrote:
> This series includes 2 fixes for regressions introduced by the XDP
> multi-buffer feature, 1 devlink reload bug fix, and 1 SRIOV resource
> accounting bug fix.
Acked-by: Jakub Kicinski <kuba@kernel.org>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH net 0/4] bnxt_en: Bug fixes
2022-08-22 15:06 [PATCH net 0/4] bnxt_en: Bug fixes Michael Chan
` (4 preceding siblings ...)
2022-08-23 3:04 ` [PATCH net 0/4] bnxt_en: Bug fixes Jakub Kicinski
@ 2022-08-23 22:40 ` patchwork-bot+netdevbpf
5 siblings, 0 replies; 22+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-08-23 22:40 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, kuba, edumazet, pabeni, gospo
Hello:
This series was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 22 Aug 2022 11:06:50 -0400 you wrote:
> This series includes 2 fixes for regressions introduced by the XDP
> multi-buffer feature, 1 devlink reload bug fix, and 1 SRIOV resource
> accounting bug fix.
>
> Pavan Chebbi (1):
> bnxt_en: Use PAGE_SIZE to init buffer when multi buffer XDP is not in
> use
>
> [...]
Here is the summary with links:
- [net,1/4] bnxt_en: Use PAGE_SIZE to init buffer when multi buffer XDP is not in use
https://git.kernel.org/netdev/net/c/7dd3de7cb1d6
- [net,2/4] bnxt_en: set missing reload flag in devlink features
https://git.kernel.org/netdev/net/c/574b2bb9692f
- [net,3/4] bnxt_en: fix NQ resource accounting during vf creation on 57500 chips
https://git.kernel.org/netdev/net/c/09a89cc59ad6
- [net,4/4] bnxt_en: fix LRO/GRO_HW features in ndo_fix_features callback
https://git.kernel.org/netdev/net/c/366c30474172
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH net 0/4] bnxt_en: Bug fixes
@ 2022-11-03 23:33 Michael Chan
2022-11-05 2:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 22+ messages in thread
From: Michael Chan @ 2022-11-03 23:33 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, edumazet, pabeni, gospo
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
This bug fix series includes fixes for PCIE AER, a crash that may occur
when doing ethtool -C in the middle of error recovery, and aRFS.
Alex Barba (1):
bnxt_en: fix potentially incorrect return value for ndo_rx_flow_steer
Michael Chan (1):
bnxt_en: Fix possible crash in bnxt_hwrm_set_coal()
Vikas Gupta (2):
bnxt_en: refactor bnxt_cancel_reservations()
bnxt_en: fix the handling of PCIE-AER
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 54 +++++++++++++++----
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
.../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +-
.../net/ethernet/broadcom/bnxt/bnxt_hwrm.c | 3 +-
4 files changed, 49 insertions(+), 11 deletions(-)
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH net 0/4] bnxt_en: Bug fixes
2022-11-03 23:33 Michael Chan
@ 2022-11-05 2:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 22+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-05 2:40 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, kuba, edumazet, pabeni, gospo
Hello:
This series was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 3 Nov 2022 19:33:23 -0400 you wrote:
> This bug fix series includes fixes for PCIE AER, a crash that may occur
> when doing ethtool -C in the middle of error recovery, and aRFS.
>
> Alex Barba (1):
> bnxt_en: fix potentially incorrect return value for ndo_rx_flow_steer
>
> Michael Chan (1):
> bnxt_en: Fix possible crash in bnxt_hwrm_set_coal()
>
> [...]
Here is the summary with links:
- [net,1/4] bnxt_en: refactor bnxt_cancel_reservations()
https://git.kernel.org/netdev/net/c/b4c66425771d
- [net,2/4] bnxt_en: fix the handling of PCIE-AER
https://git.kernel.org/netdev/net/c/0cf736a18a1e
- [net,3/4] bnxt_en: Fix possible crash in bnxt_hwrm_set_coal()
https://git.kernel.org/netdev/net/c/6d81ea3765df
- [net,4/4] bnxt_en: fix potentially incorrect return value for ndo_rx_flow_steer
https://git.kernel.org/netdev/net/c/02597d39145b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2022-11-05 2:40 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-22 15:06 [PATCH net 0/4] bnxt_en: Bug fixes Michael Chan
2022-08-22 15:06 ` [PATCH net 1/4] bnxt_en: Use PAGE_SIZE to init buffer when multi buffer XDP is not in use Michael Chan
2022-08-22 15:06 ` [PATCH net 2/4] bnxt_en: set missing reload flag in devlink features Michael Chan
2022-08-22 15:06 ` [PATCH net 3/4] bnxt_en: fix NQ resource accounting during vf creation on 57500 chips Michael Chan
2022-08-22 15:06 ` [PATCH net 4/4] bnxt_en: fix LRO/GRO_HW features in ndo_fix_features callback Michael Chan
2022-08-23 3:04 ` [PATCH net 0/4] bnxt_en: Bug fixes Jakub Kicinski
2022-08-23 22:40 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2022-11-03 23:33 Michael Chan
2022-11-05 2:40 ` patchwork-bot+netdevbpf
2020-11-16 0:27 Michael Chan
2020-11-17 1:44 ` Jakub Kicinski
2020-06-23 23:01 Michael Chan
2020-06-23 23:45 ` Jakub Kicinski
2020-06-24 3:15 ` David Miller
2020-06-14 23:57 Michael Chan
2020-06-15 20:29 ` David Miller
2020-02-02 7:41 Michael Chan
2020-02-03 23:22 ` Jakub Kicinski
2019-05-22 23:12 Michael Chan
2019-05-23 1:03 ` David Miller
2018-12-09 12:00 Michael Chan
2018-12-09 19:47 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).