From: patchwork-bot+netdevbpf@kernel.org
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net,
tglx@linutronix.de, peterz@infradead.org
Subject: Re: [PATCH net 0/2] net: u64_stats fixups for 32bit.
Date: Mon, 29 Aug 2022 12:10:15 +0000 [thread overview]
Message-ID: <166177501593.22813.2166930979852446923.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220825113645.212996-1-bigeasy@linutronix.de>
Hello:
This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 25 Aug 2022 13:36:43 +0200 you wrote:
> Hi,
>
> while looking at the u64-stats patch
> https://lore.kernel.org/all/20220817162703.728679-10-bigeasy@linutronix.de
>
> I noticed that u64_stats_fetch_begin() is used. That suspicious thing
> about it is that network processing, including stats update, is
> performed in NAPI and so I would expect to see
> u64_stats_fetch_begin_irq() in order to avoid updates from NAPI during
> the read. This is only needed on 32bit-UP where the seqcount is not
> used. This is address in 2/2. The remaining user take some kind of
> precaution and may use u64_stats_fetch_begin().
>
> [...]
Here is the summary with links:
- [net,1/2] net: dsa: xrs700x: Use irqsave variant for u64 stats update
https://git.kernel.org/netdev/net/c/3f8ae9fe0409
- [net,2/2] net: Use u64_stats_fetch_begin_irq() for stats fetch.
https://git.kernel.org/netdev/net/c/278d3ba61563
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-08-29 12:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 11:36 [PATCH net 0/2] net: u64_stats fixups for 32bit Sebastian Andrzej Siewior
2022-08-25 11:36 ` [PATCH net 1/2] net: dsa: xrs700x: Use irqsave variant for u64 stats update Sebastian Andrzej Siewior
2022-08-25 11:51 ` George McCollister
2022-08-25 11:36 ` [PATCH net 2/2] net: Use u64_stats_fetch_begin_irq() for stats fetch Sebastian Andrzej Siewior
2022-08-29 9:55 ` Simon Horman
2022-08-29 12:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166177501593.22813.2166930979852446923.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).