* [PATCH net-next] r8169: remove comment about apparently non-existing chip versions
@ 2022-09-02 20:21 Heiner Kallweit
2022-09-05 11:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2022-09-02 20:21 UTC (permalink / raw)
To: Jakub Kicinski, David Miller, Realtek linux nic maintainers,
Eric Dumazet, Paolo Abeni
Cc: netdev@vger.kernel.org
It's not clear where these entries came from, and as I wrote in the
comment: Not even Realtek's r8101 driver knows these chip id's.
So remove the comment.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 779ca268d..a8b0070bb 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -2050,12 +2050,6 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii)
{ 0x7c8, 0x348, RTL_GIGA_MAC_VER_09 },
{ 0x7c8, 0x248, RTL_GIGA_MAC_VER_09 },
{ 0x7c8, 0x340, RTL_GIGA_MAC_VER_16 },
- /* FIXME: where did these entries come from ? -- FR
- * Not even r8101 vendor driver knows these id's,
- * so let's disable detection for now. -- HK
- * { 0xfc8, 0x388, RTL_GIGA_MAC_VER_13 },
- * { 0xfc8, 0x308, RTL_GIGA_MAC_VER_13 },
- */
/* 8110 family. */
{ 0xfc8, 0x980, RTL_GIGA_MAC_VER_06 },
--
2.37.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] r8169: remove comment about apparently non-existing chip versions
2022-09-02 20:21 [PATCH net-next] r8169: remove comment about apparently non-existing chip versions Heiner Kallweit
@ 2022-09-05 11:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-05 11:50 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: kuba, davem, nic_swsd, edumazet, pabeni, netdev
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 2 Sep 2022 22:21:57 +0200 you wrote:
> It's not clear where these entries came from, and as I wrote in the
> comment: Not even Realtek's r8101 driver knows these chip id's.
> So remove the comment.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/net/ethernet/realtek/r8169_main.c | 6 ------
> 1 file changed, 6 deletions(-)
Here is the summary with links:
- [net-next] r8169: remove comment about apparently non-existing chip versions
https://git.kernel.org/netdev/net-next/c/baa71622cf67
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-05 11:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-02 20:21 [PATCH net-next] r8169: remove comment about apparently non-existing chip versions Heiner Kallweit
2022-09-05 11:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).