* [PATCH net-next] r8169: disable detection of chip version 36
@ 2022-09-09 6:00 Heiner Kallweit
2022-09-19 21:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2022-09-09 6:00 UTC (permalink / raw)
To: Jakub Kicinski, David Miller, Realtek linux nic maintainers,
Eric Dumazet, Paolo Abeni
Cc: netdev@vger.kernel.org
I found no evidence that this chip version ever made it to the mass
market. Therefore disable detection. Like in similar cases before:
If nobody complains, we'll remove support for this chip version after
few months.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 1d571af4d..8e1dae4de 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -1998,7 +1998,10 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii)
/* 8168F family. */
{ 0x7c8, 0x488, RTL_GIGA_MAC_VER_38 },
- { 0x7cf, 0x481, RTL_GIGA_MAC_VER_36 },
+ /* It seems this chip version never made it to
+ * the wild. Let's disable detection.
+ * { 0x7cf, 0x481, RTL_GIGA_MAC_VER_36 },
+ */
{ 0x7cf, 0x480, RTL_GIGA_MAC_VER_35 },
/* 8168E family. */
--
2.37.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] r8169: disable detection of chip version 36
2022-09-09 6:00 [PATCH net-next] r8169: disable detection of chip version 36 Heiner Kallweit
@ 2022-09-19 21:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-19 21:20 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: kuba, davem, nic_swsd, edumazet, pabeni, netdev
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 9 Sep 2022 08:00:22 +0200 you wrote:
> I found no evidence that this chip version ever made it to the mass
> market. Therefore disable detection. Like in similar cases before:
> If nobody complains, we'll remove support for this chip version after
> few months.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> [...]
Here is the summary with links:
- [net-next] r8169: disable detection of chip version 36
https://git.kernel.org/netdev/net-next/c/42666b2c452c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-19 21:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-09 6:00 [PATCH net-next] r8169: disable detection of chip version 36 Heiner Kallweit
2022-09-19 21:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).