From: patchwork-bot+netdevbpf@kernel.org
To: =?utf-8?b?w43DsWlnbyBIdWd1ZXQgPGlodWd1ZXRAcmVkaGF0LmNvbT4=?=@ci.codeaurora.org
Cc: ecree.xilinx@gmail.com, habetsm.xilinx@gmail.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org, tizhao@redhat.com
Subject: Re: [PATCH net] sfc: fix TX channel offset when using legacy interrupts
Date: Tue, 20 Sep 2022 01:20:14 +0000 [thread overview]
Message-ID: <166363681482.30260.9951271868233069504.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220914103648.16902-1-ihuguet@redhat.com>
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 14 Sep 2022 12:36:48 +0200 you wrote:
> In legacy interrupt mode the tx_channel_offset was hardcoded to 1, but
> that's not correct if efx_sepparate_tx_channels is false. In that case,
> the offset is 0 because the tx queues are in the single existing channel
> at index 0, together with the rx queue.
>
> Without this fix, as soon as you try to send any traffic, it tries to
> get the tx queues from an uninitialized channel getting these errors:
> WARNING: CPU: 1 PID: 0 at drivers/net/ethernet/sfc/tx.c:540 efx_hard_start_xmit+0x12e/0x170 [sfc]
> [...]
> RIP: 0010:efx_hard_start_xmit+0x12e/0x170 [sfc]
> [...]
> Call Trace:
> <IRQ>
> dev_hard_start_xmit+0xd7/0x230
> sch_direct_xmit+0x9f/0x360
> __dev_queue_xmit+0x890/0xa40
> [...]
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000020
> [...]
> RIP: 0010:efx_hard_start_xmit+0x153/0x170 [sfc]
> [...]
> Call Trace:
> <IRQ>
> dev_hard_start_xmit+0xd7/0x230
> sch_direct_xmit+0x9f/0x360
> __dev_queue_xmit+0x890/0xa40
> [...]
>
> [...]
Here is the summary with links:
- [net] sfc: fix TX channel offset when using legacy interrupts
https://git.kernel.org/netdev/net/c/f232af429565
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2022-09-20 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 10:36 [PATCH net] sfc: fix TX channel offset when using legacy interrupts Íñigo Huguet
2022-09-14 17:47 ` Edward Cree
2022-09-20 1:20 ` patchwork-bot+netdevbpf [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-14 13:15 Cooper, Jonathan Stephen (DCG-ENG)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166363681482.30260.9951271868233069504.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc==?utf-8?b?w43DsWlnbyBIdWd1ZXQgPGlodWd1ZXRAcmVkaGF0LmNvbT4=?=@ci.codeaurora.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tizhao@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).