From: patchwork-bot+netdevbpf@kernel.org
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org, cong.wang@bytedance.com,
peilin.ye@bytedance.com, john.fastabend@gmail.com,
jakub@cloudflare.com, edumazet@google.com
Subject: Re: [Patch net] tcp: read multiple skbs in tcp_read_skb()
Date: Tue, 20 Sep 2022 13:00:15 +0000 [thread overview]
Message-ID: <166367881574.10144.3048644265262767799.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220912173553.235838-1-xiyou.wangcong@gmail.com>
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 12 Sep 2022 10:35:53 -0700 you wrote:
> From: Cong Wang <cong.wang@bytedance.com>
>
> Before we switched to ->read_skb(), ->read_sock() was passed with
> desc.count=1, which technically indicates we only read one skb per
> ->sk_data_ready() call. However, for TCP, this is not true.
>
> TCP at least has sk_rcvlowat which intentionally holds skb's in
> receive queue until this watermark is reached. This means when
> ->sk_data_ready() is invoked there could be multiple skb's in the
> queue, therefore we have to read multiple skbs in tcp_read_skb()
> instead of one.
>
> [...]
Here is the summary with links:
- [net] tcp: read multiple skbs in tcp_read_skb()
https://git.kernel.org/netdev/net/c/db4192a754eb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-09-20 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 17:35 [Patch net] tcp: read multiple skbs in tcp_read_skb() Cong Wang
2022-09-20 13:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166367881574.10144.3048644265262767799.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=cong.wang@bytedance.com \
--cc=edumazet@google.com \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peilin.ye@bytedance.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).