From: patchwork-bot+netdevbpf@kernel.org
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org,
john.fastabend@gmail.com, davem@davemloft.net, ast@kernel.org,
hawk@kernel.org, daniel@iogearbox.net, edumazet@google.com,
pabeni@redhat.com, bpf@vger.kernel.org, lorenzo@kernel.org
Subject: Re: [PATCH net-next] xdp: Adjust xdp_frame layout to avoid using bitfields
Date: Tue, 27 Sep 2022 00:20:13 +0000 [thread overview]
Message-ID: <166423801357.11940.13487466744913747650.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <166393728005.2213882.4162674859542409548.stgit@firesoul>
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 23 Sep 2022 14:48:00 +0200 you wrote:
> Practical experience (and advice from Alexei) tell us that bitfields in
> structs lead to un-optimized assemply code. I've verified this change
> does lead to better x86_64 assemply, both via objdump and playing with
> code snippets in godbolt.org.
>
> Using scripts/bloat-o-meter shows the code size is reduced with 24
> bytes for xdp_convert_buff_to_frame() that gets inlined e.g. in
> i40e_xmit_xdp_tx_ring() which were used for microbenchmarking.
>
> [...]
Here is the summary with links:
- [net-next] xdp: Adjust xdp_frame layout to avoid using bitfields
https://git.kernel.org/netdev/net-next/c/b860a1b964be
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-09-27 0:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 12:48 [PATCH net-next] xdp: Adjust xdp_frame layout to avoid using bitfields Jesper Dangaard Brouer
2022-09-27 0:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166423801357.11940.13487466744913747650.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox