From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B6C829BDBB; Fri, 10 Apr 2026 01:22:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.251.229.89 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775784141; cv=none; b=u544YynQ5PCMcz+UNcP2/81ODrQEi4gdsbaprauIEJZtE572zednLlaSJiske52WP0v3Us0Xdi+JzaJj8JgV8nY2YZBaw2SdSDw+AIEpb8VBMpA1xhiVfA2eN1m/mFlJI3XWQ4PAxI73iQxRrl+DMxXOYbzscWfeNs9FNnzu2WA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775784141; c=relaxed/simple; bh=OtdwFEyEb8se/ithYk2UGLo+hYsxtwasy+75+RvYfiU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HSsd1rsviBCyWsY/gsR96Ce9Re8n4d+v6Y7oVtDlfn9+1L0TPUOjwmV+Ip0gCavZB3b/EyYCpx30pDwiOPD/nsEjKWItj0tJ5T7nXAMjDOJ/zGLwJdxQ3MtHmACOdldyBU7KtmJ84yWIJpjli4gCaA+eHXtOwkShGCexcrP8pzU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com; spf=pass smtp.mailfrom=nabladev.com; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b=T4Ia0eYl; arc=none smtp.client-ip=178.251.229.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabladev.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b="T4Ia0eYl" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id D305B113855; Fri, 10 Apr 2026 03:22:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1775784136; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=xpNGb4YWB4vk5Fw9+AtiAS5mIPWhtfd3tfy+j6rlEZM=; b=T4Ia0eYl5boquXW4npr40FUzcytcAIKE9lyrtAdx3591Gky2aF40mU8Af3gv8NpgEvKgsN lAbBE1viTgoH/4YBwzufngSIc86vujOxg+mCyzFYxl8/pbhgTXTJb4Jcd0ea0hYVLaI8XF vSNPpIekHTKkG04pQRUpb4S7G6R6JLE80XSSJpCqUbtLJJW+jAZCeIBx18NySBQXTLVITx lh3cZUZs5ukSFjFhgK3EwX6CS4ntZYCZAhNWA6J7jo2A1twBJjmyf8EfcpR9uGpzcJmhR4 Gc6bo/dVicGoP6cBoe7zCNkkSMwJkQCBHrxqUkIK8wJRI2Owk7rV083dgkG2Sg== Message-ID: <1665242a-2298-4e76-9618-effdb88c2ad4@nabladev.com> Date: Thu, 9 Apr 2026 17:26:13 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net,PATCH v2] net: ks8851: Reinstate disabling of BHs around IRQ handler To: Nicolai Buchwitz Cc: netdev@vger.kernel.org, stable@vger.kernel.org, "David S. Miller" , Andrew Lunn , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ronald Wahl , Yicong Hui , linux-kernel@vger.kernel.org References: <20260408162535.98108-1-marex@nabladev.com> <6391ee36b7d9c66d33c734650ebfb7fe@tipi-net.de> Content-Language: en-US From: Marek Vasut In-Reply-To: <6391ee36b7d9c66d33c734650ebfb7fe@tipi-net.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 On 4/9/26 8:52 AM, Nicolai Buchwitz wrote: Hello Nicolai, >> @@ -408,7 +426,9 @@ static int ks8851_net_open(struct net_device *dev) >>      unsigned long flags; >>      int ret; >> >> -    ret = request_threaded_irq(dev->irq, NULL, ks8851_irq, >> +    ret = request_threaded_irq(dev->irq, NULL, >> +                   ks->no_bh_in_irq_handler ? >> +                   ks8851_irq_nobh : ks8851_irq, > > This works, but wouldn't it be simpler to put the BH disable > into the PAR lock/unlock directly? > >   static void ks8851_lock_par(...) >   { >       local_bh_disable(); >       spin_lock_irqsave(&ksp->lock, *flags); >   } > >   static void ks8851_unlock_par(...) >   { >       spin_unlock_irqrestore(&ksp->lock, *flags); >       local_bh_enable(); >   } > > No flag, no wrapper, no conditional in request_threaded_irq. > And it protects all PAR lock/unlock callsites, not just the > IRQ handler. That is exactly why I wrapped the IRQ handler, because the BH should be disabled ONLY around the IRQ handler, not around the other call sites.