From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C1CEC4332F for ; Thu, 13 Oct 2022 01:50:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbiJMBu0 (ORCPT ); Wed, 12 Oct 2022 21:50:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229876AbiJMBuU (ORCPT ); Wed, 12 Oct 2022 21:50:20 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44CB288DEA for ; Wed, 12 Oct 2022 18:50:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E08ECB81CF0 for ; Thu, 13 Oct 2022 01:50:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 887B7C4347C; Thu, 13 Oct 2022 01:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665625816; bh=hLjnv4mrVLh5HMxyot5Mx3Iq70N97EgA069cYJUiqJ4=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=Ri9cscau/6UeuFc/hP7PMSALWfotmGZmdugUMjKvVdvW7HRxbP/TDTtFZXvXuF63r y5lwOxVZTo80527I/IRr32W2odq8rT6YNZDKjvCUSH6SNz0yh5B78zSarRwvB/uSXv ckN1go3PKcZTD8EEAn3PPC8JS93lDbOID01jsdqEgZEDkg0cUe5MowMkwyDDk1jBpb nEhkx0nzlmnELNIDcESEC1DHT/w1g9ATSBFwrhzleiThg3zSLIAwddBin9yIA9ZFbO IIXg0ZY1eRegMbH4auIB026GAcDELykO0XUl/eHkKB7nmtSC82cvVu7IqyyOaTtits CsHZcJPCL+XXg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 6E8FCE29F35; Thu, 13 Oct 2022 01:50:16 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] openvswitch: add nf_ct_is_confirmed check before assigning the helper From: patchwork-bot+netdevbpf@kernel.org Message-Id: <166562581644.26155.16251877521132982468.git-patchwork-notify@kernel.org> Date: Thu, 13 Oct 2022 01:50:16 +0000 References: In-Reply-To: To: Xin Long Cc: netdev@vger.kernel.org, dev@openvswitch.org, davem@davemloft.net, kuba@kernel.org, edumazet@google.com, pabeni@redhat.com, pshelar@ovn.org, fw@strlen.de, pablo@netfilter.org, i.maximets@ovn.org, echaudro@redhat.com, yihung.wei@gmail.com Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Thu, 6 Oct 2022 15:45:02 -0400 you wrote: > A WARN_ON call trace would be triggered when 'ct(commit, alg=helper)' > applies on a confirmed connection: > > WARNING: CPU: 0 PID: 1251 at net/netfilter/nf_conntrack_extend.c:98 > RIP: 0010:nf_ct_ext_add+0x12d/0x150 [nf_conntrack] > Call Trace: > > nf_ct_helper_ext_add+0x12/0x60 [nf_conntrack] > __nf_ct_try_assign_helper+0xc4/0x160 [nf_conntrack] > __ovs_ct_lookup+0x72e/0x780 [openvswitch] > ovs_ct_execute+0x1d8/0x920 [openvswitch] > do_execute_actions+0x4e6/0xb60 [openvswitch] > ovs_execute_actions+0x60/0x140 [openvswitch] > ovs_packet_cmd_execute+0x2ad/0x310 [openvswitch] > genl_family_rcv_msg_doit.isra.15+0x113/0x150 > genl_rcv_msg+0xef/0x1f0 > > [...] Here is the summary with links: - [net] openvswitch: add nf_ct_is_confirmed check before assigning the helper https://git.kernel.org/netdev/net/c/3c1860543fcc You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html